ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

opennebula: fix error message when renaming an image (#3626) (#3650)

Browse source 
While porting this module to make use of `pyone` I have overlooked one
attribute.  Luckily the error only occurs when trying to rename an image
to a name that has already been taken.

Instead of telling the user which image ID already uses that name, the
module failed with the following error (along with a huge backtrace):

    AttributeError: 'IMAGESub' object has no attribute 'id'

With this commit the error message is much more obvous again.

(cherry picked from commit b429c520f5)

Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
This commit is contained in:
patchback[bot] 2021-10-31 18:50:20 +01:00 committed by GitHub
parent 311b618016
commit 739719a3b1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/3626-fix-one_image-error.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- one_image - fix error message when renaming an image (https://github.com/ansible-collections/community.general/pull/3626).

2
plugins/modules/cloud/opennebula/one_image.py
View file

@ -306,7 +306,7 @@ def rename_image(module, client, image, new_name):
tmp_image = get_image_by_name(module, client, new_name) tmp_image = get_image_by_name(module, client, new_name)
if tmp_image: if tmp_image:
module.fail_json(msg="Name '" + new_name + "' is already taken by IMAGE with id=" + str(tmp_image.id)) module.fail_json(msg="Name '" + new_name + "' is already taken by IMAGE with id=" + str(tmp_image.ID))
if not module.check_mode: if not module.check_mode:
client.image.rename(image.ID, new_name) client.image.rename(image.ID, new_name)