From 726aa5ecf7c9fa069f9c4d38e28457133c373c85 Mon Sep 17 00:00:00 2001 From: thetuxkeeper Date: Sat, 14 Nov 2020 11:52:01 +0100 Subject: [PATCH] proxmox_kvm: pool parameter not supported by qemu//config API endpoint (#1258) * proxmox_kvm: pool parameter not supported by API on update * added changelog fragment * format fix and pull request link added Co-authored-by: Felix Fontein Co-authored-by: Felix Fontein --- .../fragments/1258-proxmox_kvm-ignore-pool-on-update.yaml | 2 ++ plugins/modules/cloud/misc/proxmox_kvm.py | 4 ++++ 2 files changed, 6 insertions(+) create mode 100644 changelogs/fragments/1258-proxmox_kvm-ignore-pool-on-update.yaml diff --git a/changelogs/fragments/1258-proxmox_kvm-ignore-pool-on-update.yaml b/changelogs/fragments/1258-proxmox_kvm-ignore-pool-on-update.yaml new file mode 100644 index 0000000000..8f9e9157fe --- /dev/null +++ b/changelogs/fragments/1258-proxmox_kvm-ignore-pool-on-update.yaml @@ -0,0 +1,2 @@ +bugfixes: + - proxmox_kvm - ignore unsupported ``pool`` parameter on update (https://github.com/ansible-collections/community.general/pull/1258). diff --git a/plugins/modules/cloud/misc/proxmox_kvm.py b/plugins/modules/cloud/misc/proxmox_kvm.py index c18c3c55f3..cc7c373cfb 100644 --- a/plugins/modules/cloud/misc/proxmox_kvm.py +++ b/plugins/modules/cloud/misc/proxmox_kvm.py @@ -414,6 +414,7 @@ options: - If C(yes), the VM will be updated with new value. - Cause of the operations of the API and security reasons, I have disabled the update of the following parameters - C(net, virtio, ide, sata, scsi). Per example updating C(net) update the MAC address and C(virtio) create always new disk... + - Update of C(pool) is disabled. It needs an additional API endpoint not covered by this module. type: bool default: 'no' validate_certs: @@ -828,6 +829,7 @@ def create_vm(module, proxmox, vmid, newid, node, name, memory, cpu, cores, sock del kwargs[p] # If update, don't update disk (virtio, ide, sata, scsi) and network interface + # pool parameter not supported by qemu//config endpoint on "update" (PVE 6.2) - only with "create" if update: if 'virtio' in kwargs: del kwargs['virtio'] @@ -841,6 +843,8 @@ def create_vm(module, proxmox, vmid, newid, node, name, memory, cpu, cores, sock del kwargs['net'] if 'force' in kwargs: del kwargs['force'] + if 'pool' in kwargs: + del kwargs['pool'] # Convert all dict in kwargs to elements. For hostpci[n], ide[n], net[n], numa[n], parallel[n], sata[n], scsi[n], serial[n], virtio[n] for k in list(kwargs.keys()):