1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00

ANSIBLE_REMOTE_TMP was an implementation of unified temp that was later changed

One of the earlier implementation of unified temp for 2.4 passed the
temp diretory to the remote side using this environment variable.  We
later changed it to be passed via a module parameter but forgot to
remove the environment variable.
This commit is contained in:
Toshio Kuratomi 2018-07-25 12:02:40 -07:00
parent 66b1adfc83
commit 6eacfecb73
2 changed files with 10 additions and 2 deletions

View file

@ -0,0 +1,10 @@
---
minor_changes:
- In Ansible-2.4 and above, Ansible passes the temporary directory a module
should use to the module. This is done via a module parameter
(_ansible_tmpdir). An earlier version of this which was also prototyped in
Ansible-2.4 development used an environment variable, ANSIBLE_REMOTE_TMP to
pass this information to the module instead. When we switched to using
a module parameter, the environment variable was left in by mistake.
Ansible-2.7 removes that variable. Any third party modules which relied on
it should use the module parameter instead.

View file

@ -321,8 +321,6 @@ class ActionBase(with_metaclass(ABCMeta, object)):
self._connection._shell.tmpdir = rc
if not become_unprivileged:
self._connection._shell.env.update({'ANSIBLE_REMOTE_TMP': self._connection._shell.tmpdir})
return rc
def _should_remove_tmp_path(self, tmp_path):