xfconf and xfconf_info: use do_raise (#4975) (#4993)

* remove redundant XfConfException class

* adjusted indentation in the documentaiton blocks

* add changelog fragment

(cherry picked from commit 31ef6c914b)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

changelogs/fragments/4975-xfconf-use-do-raise.yaml

@@ -0,0 +1,3 @@
+minor_changes:
+  - xfconf - use ``do_raise()`` instead of defining custom exception class (https://github.com/ansible-collections/community.general/pull/4975).
+  - xfconf_info - use ``do_raise()`` instead of defining custom exception class (https://github.com/ansible-collections/community.general/pull/4975).

plugins/modules/system/xfconf.py

@@ -149,10 +149,6 @@ from ansible_collections.community.general.plugins.module_utils.module_helper im
 from ansible_collections.community.general.plugins.module_utils.xfconf import xfconf_runner
 
 
-class XFConfException(Exception):
-    pass
-
-
 class XFConfProperty(StateModuleHelper):
     change_params = 'value',
     diff_params = 'value',
@@ -194,7 +190,7 @@ class XFConfProperty(StateModuleHelper):
         if err.rstrip() == self.does_not:
             return None
         if rc or len(err):
-            raise XFConfException('xfconf-query failed with error (rc={0}): {1}'.format(rc, err))
+            self.do_raise('xfconf-query failed with error (rc={0}): {1}'.format(rc, err))
 
         result = out.rstrip()
         if "Value is an array with" in result:
@@ -227,7 +223,7 @@ class XFConfProperty(StateModuleHelper):
             value_type = value_type * values_len
         elif types_len != values_len:
             # or complain if lists' lengths are different
-            raise XFConfException('Number of elements in "value" and "value_type" must be the same')
+            self.do_raise('Number of elements in "value" and "value_type" must be the same')
 
         # calculates if it is an array
         self.vars.is_array = \

plugins/modules/system/xfconf_info.py

@@ -120,10 +120,6 @@ from ansible_collections.community.general.plugins.module_utils.module_helper im
 from ansible_collections.community.general.plugins.module_utils.xfconf import xfconf_runner
 
 
-class XFConfException(Exception):
-    pass
-
-
 class XFConfInfo(ModuleHelper):
     module = dict(
         argument_spec=dict(
@@ -170,8 +166,10 @@ class XFConfInfo(ModuleHelper):
         elif self.vars.property is None:
             output = 'properties'
             proc = self._process_list_properties
+
         with self.runner.context('list_arg channel property', output_process=proc) as ctx:
             result = ctx.run(**self.vars)
+
         if not self.vars.list_arg and self.vars.is_array:
             output = "value_array"
         self.vars.set(output, result)