ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

make os_security_group_rule idempotent (#23707)

Browse source 
* Fix issue #19610
This commit is contained in:
Andrea Tosatto 2017-09-12 16:24:09 +02:00 • committed by Toshio Kuratomi
parent 0566d4672d
commit 6b6e5665aa
1 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
lib/ansible/modules/cloud/openstack/os_security_group_rule.py
View file

@ -208,12 +208,17 @@ def _ports_match(protocol, module_min, module_max, rule_min, rule_max):
if module_max and int(module_max) == -1: if module_max and int(module_max) == -1:
module_max = None module_max = None
# Check if user is supplying None values for full TCP/UDP port range. # Check if the user is supplying -1 or None values for full TPC/UDP port range.
if protocol in ['tcp', 'udp'] and module_min is None and module_max is None: if protocol in ['tcp', 'udp'] or protocol is None:
if (rule_min and int(rule_min) == 1 if module_min and module_max and int(module_min) == int(module_max) == -1:
and rule_max and int(rule_max) == 65535): module_min = None
# (None, None) == (1, 65535) module_max = None
return True
if ((module_min is None and module_max is None) and
(rule_min and int(rule_min) == 1 and
rule_max and int(rule_max) == 65535)):
# (None, None) == (1, 65535)
return True
# Sanity check to make sure we don't have type comparison issues. # Sanity check to make sure we don't have type comparison issues.
if module_min: if module_min: