From 67a70a1205b3e7e52063c15c8a7df4e5c6950451 Mon Sep 17 00:00:00 2001 From: Bob Vincent Date: Tue, 27 Nov 2018 11:38:53 -0500 Subject: [PATCH] Improve docs for umask option of pip module. (#49146) * Improve docs for umask option of pip module; umask should be specified as an octal *string*, not an octal (or decimal) *integer*. --- lib/ansible/modules/packaging/language/pip.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/ansible/modules/packaging/language/pip.py b/lib/ansible/modules/packaging/language/pip.py index c58ce92f01..5863d770f4 100644 --- a/lib/ansible/modules/packaging/language/pip.py +++ b/lib/ansible/modules/packaging/language/pip.py @@ -98,9 +98,12 @@ options: description: - The system umask to apply before installing the pip package. This is useful, for example, when installing on systems that have a very - restrictive umask by default (e.g., 0077) and you want to pip install + restrictive umask by default (e.g., "0077") and you want to pip install packages which are to be used by all users. Note that this requires you - to specify desired umask mode in octal, with a leading 0 (e.g., 0077). + to specify desired umask mode as an octal string, (e.g., "0022"). + Specifying the mode as a decimal integer (e.g., 22) will also work, but + an octal integer (e.g., 0022) will be converted to decimal (18) before + evaluation, which is almost certainly not what was intended. version_added: "2.1" notes: - Please note that virtualenv (U(http://www.virtualenv.org/)) must be