ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

use module required_if so if statements not needed (#28)

Browse source 
Co-authored-by: cwollinger <cwollinger@localhost.localdomain>
This commit is contained in:
CWollinger 2020-03-23 14:41:49 +00:00 committed by GitHub
parent 76e72c44cd
commit 676bec5484
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
plugins/modules/net_tools/ipwcli_dns.py
View file

@ -188,39 +188,18 @@ class ResourceRecord(object):
def create_naptrrecord(self): def create_naptrrecord(self):
# create NAPTR record with the given params # create NAPTR record with the given params
if not self.preference:
self.module.fail_json(msg='missing required arguments for NAPTR record: preference')
if not self.order:
self.module.fail_json(msg='missing required arguments for NAPTR record: order')
if not self.service:
self.module.fail_json(msg='missing required arguments for NAPTR record: service')
if not self.replacement:
self.module.fail_json(msg='missing required arguments for NAPTR record: replacement')
record = ('naptrrecord %s -set ttl=%s;container=%s;order=%s;preference=%s;flags="%s";service="%s";replacement="%s"' record = ('naptrrecord %s -set ttl=%s;container=%s;order=%s;preference=%s;flags="%s";service="%s";replacement="%s"'
% (self.dnsname, self.ttl, self.container, self.order, self.preference, self.flags, self.service, self.replacement)) % (self.dnsname, self.ttl, self.container, self.order, self.preference, self.flags, self.service, self.replacement))
return record return record
def create_srvrecord(self): def create_srvrecord(self):
# create SRV record with the given params # create SRV record with the given params
if not self.port:
self.module.fail_json(msg='missing required arguments for SRV record: port')
if not self.target:
self.module.fail_json(msg='missing required arguments for SRV record: target')
record = ('srvrecord %s -set ttl=%s;container=%s;priority=%s;weight=%s;port=%s;target=%s' record = ('srvrecord %s -set ttl=%s;container=%s;priority=%s;weight=%s;port=%s;target=%s'
% (self.dnsname, self.ttl, self.container, self.priority, self.weight, self.port, self.target)) % (self.dnsname, self.ttl, self.container, self.priority, self.weight, self.port, self.target))
return record return record
def create_arecord(self): def create_arecord(self):
# create A record with the given params # create A record with the given params
if not self.address:
self.module.fail_json(msg='missing required arguments for A record: address')
if self.dnstype == 'AAAA': if self.dnstype == 'AAAA':
record = 'aaaarecord %s %s -set ttl=%s;container=%s' % (self.dnsname, self.address, self.ttl, self.container) record = 'aaaarecord %s %s -set ttl=%s;container=%s' % (self.dnsname, self.address, self.ttl, self.container)
else: else:
@ -312,6 +291,12 @@ def run_module():
# supports check mode # supports check mode
module = AnsibleModule( module = AnsibleModule(
argument_spec=module_args, argument_spec=module_args,
required_if=[
['type', 'A', ['address']],
['type', 'AAAA', ['address']],
['type', 'SRV', ['port', 'target']],
['type', 'NAPTR', ['preference', 'order', 'service', 'replacement']],
],
supports_check_mode=True supports_check_mode=True
) )