ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Fix handling of ReaderError in validate-modules.

Browse source
This commit is contained in:
Matt Clay 2016-11-09 00:17:03 -08:00
parent d1b41d8f9c
commit 65f019fe82
1 changed files with 17 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
test/sanity/validate-modules/validate-modules
View file

@ -41,6 +41,7 @@ from schema import doc_schema, option_schema
from utils import CaptureStd from utils import CaptureStd
import yaml import yaml
import yaml.reader
BLACKLIST_DIRS = frozenset(('.git', 'test', '.github', '.idea')) BLACKLIST_DIRS = frozenset(('.git', 'test', '.github', '.idea'))
@ -383,7 +384,7 @@ class ModuleValidator(Validator):
doc_info = self._get_docs() doc_info = self._get_docs()
try: try:
doc = yaml.safe_load(doc_info['DOCUMENTATION']['value']) doc = yaml.safe_load(doc_info['DOCUMENTATION']['value'])
except yaml.YAMLError as e: except yaml.MarkedYAMLError as e:
doc = None doc = None
# This offsets the error line number to where the # This offsets the error line number to where the
# DOCUMENTATION starts so we can just go to that line in the # DOCUMENTATION starts so we can just go to that line in the
@ -397,6 +398,13 @@ class ModuleValidator(Validator):
'column %d' % 'column %d' %
(e.problem_mark.line + 1, (e.problem_mark.line + 1,
e.problem_mark.column + 1)) e.problem_mark.column + 1))
except yaml.reader.ReaderError as e:
self.traces.append(e)
self.errors.append('DOCUMENTATION is not valid YAML. Character 0x%x at position %d.' %
(e.character, e.position))
except yaml.YAMLError as e:
self.traces.append(e)
self.errors.append('DOCUMENTATION is not valid YAML: %s: %s' % (type(e), e))
except AttributeError: except AttributeError:
self.errors.append('No DOCUMENTATION provided') self.errors.append('No DOCUMENTATION provided')
else: else:
@ -427,7 +435,7 @@ class ModuleValidator(Validator):
else: else:
try: try:
yaml.safe_load(doc_info['RETURN']['value']) yaml.safe_load(doc_info['RETURN']['value'])
except yaml.YAMLError as e: except yaml.MarkedYAMLError as e:
e.problem_mark.line += ( e.problem_mark.line += (
doc_info['RETURN']['lineno'] - 1 doc_info['RETURN']['lineno'] - 1
) )
@ -437,6 +445,13 @@ class ModuleValidator(Validator):
(e.problem_mark.line + 1, (e.problem_mark.line + 1,
e.problem_mark.column + 1)) e.problem_mark.column + 1))
self.traces.append(e) self.traces.append(e)
except yaml.reader.ReaderError as e:
self.traces.append(e)
self.errors.append('RETURN is not valid YAML. Character 0x%x at position %d.' %
(e.character, e.position))
except yaml.YAMLError as e:
self.traces.append(e)
self.errors.append('RETURN is not valid YAML: %s: %s' % (type(e), e))
def _check_version_added(self, doc): def _check_version_added(self, doc):
if not self._is_new_module(): if not self._is_new_module():