Fixed sanity checks for cloud/online/ modules (#2677) (#2679)

* fixed validation-modules for plugins/modules/cloud/online/online_server_info.py

* fixed validation-modules for plugins/modules/cloud/online/online_user_info.py

* sanity fix

(cherry picked from commit bef3c04d1c)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

plugins/modules/cloud/online/online_server_info.py

@@ -32,11 +32,13 @@ EXAMPLES = r'''
 '''
 
 RETURN = r'''
----
 online_server_info:
-  description: Response from Online API
+  description:
+    - Response from Online API.
+    - "For more details please refer to: U(https://console.online.net/en/api/)."
   returned: success
-  type: complex
+  type: list
+  elements: dict
   sample:
     "online_server_info": [
         {

plugins/modules/cloud/online/online_user_info.py

@@ -7,7 +7,6 @@ from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 
 DOCUMENTATION = r'''
----
 module: online_user_info
 short_description: Gather information about Online user.
 description:
@@ -16,7 +15,6 @@ author:
   - "Remy Leone (@sieben)"
 extends_documentation_fragment:
 - community.general.online
-
 '''
 
 EXAMPLES = r'''
@@ -29,11 +27,12 @@ EXAMPLES = r'''
 '''
 
 RETURN = r'''
----
 online_user_info:
-  description: Response from Online API
+  description:
+    - Response from Online API.
+    - "For more details please refer to: U(https://console.online.net/en/api/)."
   returned: success
-  type: complex
+  type: dict
   sample:
     "online_user_info": {
         "company": "foobar LLC",

tests/sanity/ignore-2.10.txt

@@ -6,8 +6,6 @@ plugins/module_utils/_mount.py metaclass-boilerplate
 plugins/modules/cloud/lxc/lxc_container.py use-argspec-type-path
 plugins/modules/cloud/lxc/lxc_container.py validate-modules:use-run-command-not-popen
 plugins/modules/cloud/misc/rhevm.py validate-modules:parameter-state-invalid-choice
-plugins/modules/cloud/online/online_server_info.py validate-modules:return-syntax-error
-plugins/modules/cloud/online/online_user_info.py validate-modules:return-syntax-error
 plugins/modules/cloud/rackspace/rax.py use-argspec-type-path # fix needed
 plugins/modules/cloud/rackspace/rax_files.py validate-modules:parameter-state-invalid-choice
 plugins/modules/cloud/rackspace/rax_files_objects.py use-argspec-type-path

tests/sanity/ignore-2.11.txt

@@ -5,8 +5,6 @@ plugins/module_utils/_mount.py metaclass-boilerplate
 plugins/modules/cloud/lxc/lxc_container.py use-argspec-type-path
 plugins/modules/cloud/lxc/lxc_container.py validate-modules:use-run-command-not-popen
 plugins/modules/cloud/misc/rhevm.py validate-modules:parameter-state-invalid-choice
-plugins/modules/cloud/online/online_server_info.py validate-modules:return-syntax-error
-plugins/modules/cloud/online/online_user_info.py validate-modules:return-syntax-error
 plugins/modules/cloud/rackspace/rax.py use-argspec-type-path # fix needed
 plugins/modules/cloud/rackspace/rax_files.py validate-modules:parameter-state-invalid-choice
 plugins/modules/cloud/rackspace/rax_files_objects.py use-argspec-type-path

tests/sanity/ignore-2.12.txt

@@ -5,8 +5,6 @@ plugins/module_utils/_mount.py metaclass-boilerplate
 plugins/modules/cloud/lxc/lxc_container.py use-argspec-type-path
 plugins/modules/cloud/lxc/lxc_container.py validate-modules:use-run-command-not-popen
 plugins/modules/cloud/misc/rhevm.py validate-modules:parameter-state-invalid-choice
-plugins/modules/cloud/online/online_server_info.py validate-modules:return-syntax-error
-plugins/modules/cloud/online/online_user_info.py validate-modules:return-syntax-error
 plugins/modules/cloud/rackspace/rax.py use-argspec-type-path # fix needed
 plugins/modules/cloud/rackspace/rax_files.py validate-modules:parameter-state-invalid-choice
 plugins/modules/cloud/rackspace/rax_files_objects.py use-argspec-type-path

tests/sanity/ignore-2.9.txt

@@ -5,8 +5,6 @@ plugins/module_utils/_mount.py future-import-boilerplate
 plugins/module_utils/_mount.py metaclass-boilerplate
 plugins/modules/cloud/lxc/lxc_container.py use-argspec-type-path
 plugins/modules/cloud/lxc/lxc_container.py validate-modules:use-run-command-not-popen
-plugins/modules/cloud/online/online_server_info.py validate-modules:return-syntax-error
-plugins/modules/cloud/online/online_user_info.py validate-modules:return-syntax-error
 plugins/modules/cloud/rackspace/rax.py use-argspec-type-path
 plugins/modules/cloud/rackspace/rax_files_objects.py use-argspec-type-path
 plugins/modules/cloud/rackspace/rax_scaling_group.py use-argspec-type-path  # fix needed, expanduser() applied to dict values