From 63279823a77320b8cdf7f69d61af6eddaa5ebf33 Mon Sep 17 00:00:00 2001 From: Brian Coca Date: Tue, 11 Dec 2018 15:21:18 -0500 Subject: [PATCH] allow caller to deal with timeout (#49449) * allow caller to deal with timeout a start for #43884 and timeout issues in long operations --- lib/ansible/module_utils/basic.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/ansible/module_utils/basic.py b/lib/ansible/module_utils/basic.py index c5f9a819be..01c90d54f6 100644 --- a/lib/ansible/module_utils/basic.py +++ b/lib/ansible/module_utils/basic.py @@ -2605,7 +2605,7 @@ class AnsibleModule(object): def run_command(self, args, check_rc=False, close_fds=True, executable=None, data=None, binary_data=False, path_prefix=None, cwd=None, use_unsafe_shell=False, prompt_regex=None, environ_update=None, umask=None, encoding='utf-8', errors='surrogate_or_strict', - expand_user_and_vars=True, pass_fds=None, before_communicate_callback=None): + expand_user_and_vars=True, pass_fds=None, before_communicate_callback=None, raise_timeouts=False): ''' Execute a command, returns rc, stdout, and stderr. @@ -2655,6 +2655,9 @@ class AnsibleModule(object): after ``Popen`` object will be created but before communicating to the process. (``Popen`` object will be passed to callback as a first argument) + :kw raise_timeouts: This is a boolean, which when True, will allow the + caller to deal with timeout exceptions. When false we use the previous + behaviour of having run_command directly call fail_json when they occur. :returns: A 3-tuple of return code (integer), stdout (native string), and stderr (native string). On python2, stdout and stderr are both byte strings. On python3, stdout and stderr are text strings converted @@ -2828,6 +2831,12 @@ class AnsibleModule(object): cmd.stderr.close() rc = cmd.returncode + except TimeoutError as e: + self.log("Timeout Executing CMD:%s Timeout :%s" % (self._clean_args(args), to_native(e))) + if raise_timeouts: + raise e + else: + self.fail_json(rc=e.errno, msg=to_native(e), cmd=self._clean_args(args)) except (OSError, IOError) as e: self.log("Error Executing CMD:%s Exception:%s" % (self._clean_args(args), to_native(e))) self.fail_json(rc=e.errno, msg=to_native(e), cmd=self._clean_args(args))