diff --git a/lib/ansible/modules/extras/system/firewalld.py b/lib/ansible/modules/extras/system/firewalld.py index 012275bf1b..f26a781f57 100644 --- a/lib/ansible/modules/extras/system/firewalld.py +++ b/lib/ansible/modules/extras/system/firewalld.py @@ -257,6 +257,8 @@ def main(): ), supports_check_mode=True ) + if module.params['source'] == None and module.params['permanent'] == None: + module.fail_json(msg='permanent is a required parameter') if not HAS_FIREWALLD: module.fail_json(msg='firewalld and its python 2 module are required for this module')