1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00

Fix/cs resoucelimit pep8 (#22102)

* cloudstack: cs_resourcelimit: fix type for limit

* cloudstack: cs_resourcelimit: fix pep8
This commit is contained in:
René Moser 2017-03-01 12:41:26 +01:00 committed by John R Barker
parent 8032c9a715
commit 60aa3db1ad

View file

@ -120,22 +120,30 @@ project:
''' '''
# import cloudstack common # import cloudstack common
from ansible.module_utils.cloudstack import * from ansible.module_utils.basic import AnsibleModule
from ansible.module_utils.cloudstack import (
AnsibleCloudStack,
CloudStackException,
cs_required_together,
cs_argument_spec
)
RESOURCE_TYPES = { RESOURCE_TYPES = {
'instance': 0, 'instance': 0,
'ip_address': 1, 'ip_address': 1,
'volume': 2, 'volume': 2,
'snapshot': 3, 'snapshot': 3,
'template': 4, 'template': 4,
'network': 6, 'network': 6,
'vpc': 7, 'vpc': 7,
'cpu': 8, 'cpu': 8,
'memory': 9, 'memory': 9,
'primary_storage': 10, 'primary_storage': 10,
'secondary_storage': 11, 'secondary_storage': 11,
} }
class AnsibleCloudStackResourceLimit(AnsibleCloudStack): class AnsibleCloudStackResourceLimit(AnsibleCloudStack):
def __init__(self, module): def __init__(self, module):
@ -144,33 +152,34 @@ class AnsibleCloudStackResourceLimit(AnsibleCloudStack):
'max': 'limit', 'max': 'limit',
} }
def get_resource_type(self): def get_resource_type(self):
resource_type = self.module.params.get('resource_type') resource_type = self.module.params.get('resource_type')
return RESOURCE_TYPES.get(resource_type) return RESOURCE_TYPES.get(resource_type)
def get_resource_limit(self): def get_resource_limit(self):
args = {} args = {
args['account'] = self.get_account(key='name') 'account': self.get_account(key='name'),
args['domainid'] = self.get_domain(key='id') 'domainid': self.get_domain(key='id'),
args['projectid'] = self.get_project(key='id') 'projectid': self.get_project(key='id'),
args['resourcetype'] = self.get_resource_type() 'resourcetype': self.get_resource_type()
}
resource_limit = self.cs.listResourceLimits(**args) resource_limit = self.cs.listResourceLimits(**args)
if resource_limit: if resource_limit:
if 'limit' in resource_limit['resourcelimit'][0]:
resource_limit['resourcelimit'][0]['limit'] = int(resource_limit['resourcelimit'][0])
return resource_limit['resourcelimit'][0] return resource_limit['resourcelimit'][0]
self.module.fail_json(msg="Resource limit type '%s' not found." % self.module.params.get('resource_type')) self.module.fail_json(msg="Resource limit type '%s' not found." % self.module.params.get('resource_type'))
def update_resource_limit(self): def update_resource_limit(self):
resource_limit = self.get_resource_limit() resource_limit = self.get_resource_limit()
args = {} args = {
args['account'] = self.get_account(key='name') 'account': self.get_account(key='name'),
args['domainid'] = self.get_domain(key='id') 'domainid': self.get_domain(key='id'),
args['projectid'] = self.get_project(key='id') 'projectid': self.get_project(key='id'),
args['resourcetype'] = self.get_resource_type() 'resourcetype': self.get_resource_type(),
args['max'] = self.module.params.get('limit', -1) 'max': self.module.params.get('limit', -1)
}
if self.has_changed(args, resource_limit): if self.has_changed(args, resource_limit):
self.result['changed'] = True self.result['changed'] = True
@ -181,7 +190,6 @@ class AnsibleCloudStackResourceLimit(AnsibleCloudStack):
resource_limit = res['resourcelimit'] resource_limit = res['resourcelimit']
return resource_limit return resource_limit
def get_result(self, resource_limit): def get_result(self, resource_limit):
self.result = super(AnsibleCloudStackResourceLimit, self).get_result(resource_limit) self.result = super(AnsibleCloudStackResourceLimit, self).get_result(resource_limit)
self.result['resource_type'] = self.module.params.get('resource_type') self.result['resource_type'] = self.module.params.get('resource_type')
@ -191,11 +199,11 @@ class AnsibleCloudStackResourceLimit(AnsibleCloudStack):
def main(): def main():
argument_spec = cs_argument_spec() argument_spec = cs_argument_spec()
argument_spec.update(dict( argument_spec.update(dict(
resource_type = dict(required=True, choices=RESOURCE_TYPES.keys(), aliases=['type']), resource_type=dict(required=True, choices=RESOURCE_TYPES.keys(), aliases=['type']),
limit = dict(default=-1, aliases=['max']), limit=dict(default=-1, aliases=['max'], type='int'),
domain = dict(default=None), domain=dict(default=None),
account = dict(default=None), account=dict(default=None),
project = dict(default=None), project=dict(default=None),
)) ))
module = AnsibleModule( module = AnsibleModule(
@ -214,7 +222,6 @@ def main():
module.exit_json(**result) module.exit_json(**result)
# import module snippets
from ansible.module_utils.basic import *
if __name__ == '__main__': if __name__ == '__main__':
main() main()