ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Only cache task.loop when delegated_host was templated. Fixes #43016 #43449 (#43451)

Browse source
This commit is contained in:
Matt Martz 2018-07-31 15:58:53 -05:00 • committed by GitHub
parent e7e63ec1e8
commit 5f98a5a736
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
lib/ansible/vars/manager.py
View file

@ -503,24 +503,16 @@ class VariableManager:
# This task will be skipped later due to this, so we just setup # This task will be skipped later due to this, so we just setup
# a dummy array for the later code so it doesn't fail # a dummy array for the later code so it doesn't fail
items = [None] items = [None]
# Update task.loop with templated items, this ensures that delegate_to+loop
# doesn't produce different restuls than TaskExecutor which may reprocess the loop
# Set loop_with to None, so we don't do extra unexpected processing on the cached items later
# in TaskExecutor
task.loop_with = None
task.loop = items
else: else:
raise AnsibleError("Failed to find the lookup named '%s' in the available lookup plugins" % task.loop_with) raise AnsibleError("Failed to find the lookup named '%s' in the available lookup plugins" % task.loop_with)
elif task.loop is not None: elif task.loop is not None:
items = templar.template(task.loop) items = templar.template(task.loop)
# Update task.loop with templated items, this ensures that delegate_to+loop
# doesn't produce different restuls than TaskExecutor which may reprocess the loop
task.loop = items
else: else:
items = [None] items = [None]
delegated_host_vars = dict() delegated_host_vars = dict()
item_var = getattr(task.loop_control, 'loop_var', 'item') item_var = getattr(task.loop_control, 'loop_var', 'item')
cache_items = False
for item in items: for item in items:
# update the variables with the item value for templating, in case we need it # update the variables with the item value for templating, in case we need it
if item is not None: if item is not None:
@ -528,6 +520,8 @@ class VariableManager:
templar.set_available_variables(vars_copy) templar.set_available_variables(vars_copy)
delegated_host_name = templar.template(task.delegate_to, fail_on_undefined=False) delegated_host_name = templar.template(task.delegate_to, fail_on_undefined=False)
if delegated_host_name != task.delegate_to:
cache_items = True
if delegated_host_name is None: if delegated_host_name is None:
raise AnsibleError(message="Undefined delegate_to host for task:", obj=task._ds) raise AnsibleError(message="Undefined delegate_to host for task:", obj=task._ds)
if delegated_host_name in delegated_host_vars: if delegated_host_name in delegated_host_vars:
@ -583,6 +577,16 @@ class VariableManager:
include_delegate_to=False, include_delegate_to=False,
include_hostvars=False, include_hostvars=False,
) )
if cache_items:
# delegate_to templating produced a change, update task.loop with templated items,
# this ensures that delegate_to+loop doesn't produce different results than TaskExecutor
# which may reprocess the loop
# Set loop_with to None, so we don't do extra unexpected processing on the cached items later
# in TaskExecutor
task.loop_with = None
task.loop = items
return delegated_host_vars return delegated_host_vars
def clear_facts(self, hostname): def clear_facts(self, hostname):