1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00

pkgng: fix #3428; install from local file

Fixes a bug in which the module reported failure
when installing from a local (to the target host)
file path.

Fixes #3428
This commit is contained in:
Ross Williams 2021-10-13 19:20:45 +00:00
parent 75212ad73d
commit 5f94eac41f
3 changed files with 45 additions and 2 deletions

View file

@ -2,3 +2,4 @@ bugfixes:
- 'pkgng - ``name=* state=latest`` check for upgrades did not count "Number of packages to be reinstalled" as a `changed` action, giving incorrect results in both regular and check mode (https://github.com/ansible-collections/community.general/pull/3526).' - 'pkgng - ``name=* state=latest`` check for upgrades did not count "Number of packages to be reinstalled" as a `changed` action, giving incorrect results in both regular and check mode (https://github.com/ansible-collections/community.general/pull/3526).'
- 'pkgng - an `earlier PR <https://github.com/ansible-collections/community.general/pull/3393>`_ broke check mode so that the module always reports `not changed`. This is now fixed so that the module reports number of upgrade or install actions that would be performed (https://github.com/ansible-collections/community.general/pull/3526).' - 'pkgng - an `earlier PR <https://github.com/ansible-collections/community.general/pull/3393>`_ broke check mode so that the module always reports `not changed`. This is now fixed so that the module reports number of upgrade or install actions that would be performed (https://github.com/ansible-collections/community.general/pull/3526).'
- 'pkgng - the ``annotation`` functionality was broken and is now fixed, and now also works with check mode (https://github.com/ansible-collections/community.general/pull/3526).' - 'pkgng - the ``annotation`` functionality was broken and is now fixed, and now also works with check mode (https://github.com/ansible-collections/community.general/pull/3526).'
- 'pkgng - installing a package from a local (to the target host) file reported failure on success `#3428 <https://github.com/ansible-collections/community.general/issues/3428>`_

View file

@ -140,6 +140,7 @@ EXAMPLES = '''
from collections import defaultdict from collections import defaultdict
import os.path
import re import re
from ansible.module_utils.basic import AnsibleModule from ansible.module_utils.basic import AnsibleModule
@ -154,6 +155,23 @@ def query_package(module, run_pkgng, name):
return False return False
def query_package_name(module, run_pkgng, package):
# Borrowing this pkg filename detection logic from
# https://github.com/freebsd/pkg/blob/06b59b5/libpkg/pkg_jobs.c#L193-L237
filename_match = re.search(r'\.(pkg|tzst|t[xbg]z|tar)', package, re.IGNORECASE)
if filename_match is not None and os.path.exists(package):
rc, out, err = run_pkgng('query', '-F', package, '%n')
if rc != 0:
module.fail_json(msg="failed to get name from package file %s: %s" % (package, out), stderr=err)
package_name = out.strip()
else:
package_name = package
return package_name
def query_update(module, run_pkgng, name): def query_update(module, run_pkgng, name):
# Check to see if a package upgrade is available. # Check to see if a package upgrade is available.
@ -273,10 +291,12 @@ def install_packages(module, run_pkgng, packages, cached, state):
# individually verify packages are in requested state # individually verify packages are in requested state
for package in package_list: for package in package_list:
verified = False verified = False
package_name = query_package_name(module, run_pkgng, package)
if action == 'install': if action == 'install':
verified = query_package(module, run_pkgng, package) verified = query_package(module, run_pkgng, package_name)
elif action == 'upgrade': elif action == 'upgrade':
verified = not query_update(module, run_pkgng, package) verified = not query_update(module, run_pkgng, package_name)
if verified: if verified:
action_count[action] += 1 action_count[action] += 1

View file

@ -136,6 +136,28 @@
- pkgng_example4.changed - pkgng_example4.changed
- not pkgng_example4_idempotent.changed - not pkgng_example4_idempotent.changed
##
## pkgng - example - Install package from local file
- name: Create test package
import_tasks: create-outofdate-pkg.yml
- name: Install test package from local file
pkgng:
name: '{{ pkgng_test_outofdate_pkg_path }}'
register: pkgng_example_localfile
- name: Remove test package
pkgng:
name: '{{ pkgng_test_pkg_name }}'
state: absent
register: pkgng_example_localfile_cleanup
- name: Ensure pkgng installs package from local file
assert:
that:
- pkgng_example_localfile.changed
- pkgng_example_localfile_cleanup.changed
## ##
## pkgng - example - Install multiple packages in one command ## pkgng - example - Install multiple packages in one command
## ##