1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00

Merge pull request #4811 from dragon3/duplicate_download_s3file

Remove duplicate "download_s3file" execution when the destination path doesn't exist
This commit is contained in:
jctanner 2013-11-05 16:00:33 -08:00
commit 5eab293421

View file

@ -343,10 +343,6 @@ def main():
else: else:
module.fail_json(msg="WARNING: Checksums do not match. Use overwrite parameter to force download.", failed=True) module.fail_json(msg="WARNING: Checksums do not match. Use overwrite parameter to force download.", failed=True)
# If destination file doesn't already exist we can go ahead and download.
if pathrtn is False:
download_s3file(module, s3, bucket, obj, dest)
# Firstly, if key_matches is TRUE and overwrite is not enabled, we EXIT with a helpful message. # Firstly, if key_matches is TRUE and overwrite is not enabled, we EXIT with a helpful message.
if sum_matches is True and overwrite is False: if sum_matches is True and overwrite is False:
module.exit_json(msg="Local and remote object are identical, ignoring. Use overwrite parameter to force.", changed=False) module.exit_json(msg="Local and remote object are identical, ignoring. Use overwrite parameter to force.", changed=False)