ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Remove unicode escape (#17866)

Browse source 
* Remove unicode-escape which is not present on python3

Alternative fix for #17305

* Enable the assemble test on python3

* Fix other problems with assemble on python3
This commit is contained in:
Toshio Kuratomi 2016-10-02 22:12:51 -07:00 committed by GitHub
parent ddb3f91562
commit 5bc3cb278c
2 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
lib/ansible/plugins/action/assemble.py
View file

@ -1,6 +1,7 @@
# (c) 2013-2014, Michael DeHaan <michael.dehaan@gmail.com> # (c) 2013-2016, Michael DeHaan <michael.dehaan@gmail.com>
# Stephen Fromm <sfromm@gmail.com> # Stephen Fromm <sfromm@gmail.com>
# Brian Coca <briancoca+dev@gmail.com> # Brian Coca <briancoca+dev@gmail.com>
# Toshio Kuratomi <tkuratomi@ansible.com>
# #
# This file is part of Ansible # This file is part of Ansible
# #
@ -18,10 +19,11 @@
from __future__ import (absolute_import, division, print_function) from __future__ import (absolute_import, division, print_function)
__metaclass__ = type __metaclass__ = type
import codecs
import os import os
import os.path import os.path
import tempfile
import re import re
import tempfile
from ansible.errors import AnsibleError from ansible.errors import AnsibleError
from ansible.module_utils._text import to_native, to_text from ansible.module_utils._text import to_native, to_text
@ -38,7 +40,7 @@ class ActionModule(ActionBase):
''' assemble a file from a directory of fragments ''' ''' assemble a file from a directory of fragments '''
tmpfd, temp_path = tempfile.mkstemp() tmpfd, temp_path = tempfile.mkstemp()
tmp = os.fdopen(tmpfd,'w') tmp = os.fdopen(tmpfd, 'wb')
delimit_me = False delimit_me = False
add_newline = False add_newline = False
@ -49,26 +51,26 @@ class ActionModule(ActionBase):
if not os.path.isfile(fragment) or (ignore_hidden and os.path.basename(fragment).startswith('.')): if not os.path.isfile(fragment) or (ignore_hidden and os.path.basename(fragment).startswith('.')):
continue continue
fragment_content = open(self._loader.get_real_file(fragment)).read() fragment_content = open(self._loader.get_real_file(fragment), 'rb').read()
# always put a newline between fragments if the previous fragment didn't end with a newline. # always put a newline between fragments if the previous fragment didn't end with a newline.
if add_newline: if add_newline:
tmp.write('\n') tmp.write(b'\n')
# delimiters should only appear between fragments # delimiters should only appear between fragments
if delimit_me: if delimit_me:
if delimiter: if delimiter:
# un-escape anything like newlines # un-escape anything like newlines
delimiter = delimiter.decode('unicode-escape') delimiter = codecs.escape_decode(delimiter)[0]
tmp.write(delimiter) tmp.write(delimiter)
# always make sure there's a newline after the # always make sure there's a newline after the
# delimiter, so lines don't run together # delimiter, so lines don't run together
if delimiter[-1] != '\n': if delimiter[-1] != b'\n':
tmp.write('\n') tmp.write(b'\n')
tmp.write(fragment_content) tmp.write(fragment_content)
delimit_me = True delimit_me = True
if fragment_content.endswith('\n'): if fragment_content.endswith(b'\n'):
add_newline = False add_newline = False
else: else:
add_newline = True add_newline = True

1
test/utils/shippable/python3-test-tag-blacklist.txt
View file

@ -1,5 +1,4 @@
test_apache2_module test_apache2_module
test_assemble
test_authorized_key test_authorized_key
test_filters test_filters
test_gem test_gem