From 56055d4f1e2d7958de196957da93851592afb131 Mon Sep 17 00:00:00 2001 From: "patchback[bot]" <45432694+patchback[bot]@users.noreply.github.com> Date: Sun, 3 Jan 2021 12:43:56 +0100 Subject: [PATCH] Remove bridge-slave from list of IP based connections (#1517) (#1577) * Removed the bridge-slave from list of ip based connections since nmcli does not accept IP options for bridge-slave connections. * Update changelogs/fragments/1517-bridge-slave-from-list-of-ip-based-connections.yml Thanks for the tip. Co-authored-by: Felix Fontein Co-authored-by: Felix Fontein (cherry picked from commit fd741ed663d0053b29744441b95c7e75d64977ba) Co-authored-by: momcilo78 --- .../1517-bridge-slave-from-list-of-ip-based-connections.yml | 2 ++ plugins/modules/net_tools/nmcli.py | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/1517-bridge-slave-from-list-of-ip-based-connections.yml diff --git a/changelogs/fragments/1517-bridge-slave-from-list-of-ip-based-connections.yml b/changelogs/fragments/1517-bridge-slave-from-list-of-ip-based-connections.yml new file mode 100644 index 0000000000..7239e5f9b5 --- /dev/null +++ b/changelogs/fragments/1517-bridge-slave-from-list-of-ip-based-connections.yml @@ -0,0 +1,2 @@ +bugfixes: + - nmcli - remove ``bridge-slave`` from list of IP based connections ((https://github.com/ansible-collections/community.general/issues/1500). diff --git a/plugins/modules/net_tools/nmcli.py b/plugins/modules/net_tools/nmcli.py index 28a8223f2b..6062629482 100644 --- a/plugins/modules/net_tools/nmcli.py +++ b/plugins/modules/net_tools/nmcli.py @@ -739,7 +739,6 @@ class Nmcli(object): return self.type in ( 'bond', 'bridge', - 'bridge-slave', 'ethernet', 'generic', 'team',