ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

opentelemetry: no_log:true causes exception when generating trace (#4043)

Browse source 
* dont check for urls when args is None

* add changelog fragment

* fix lint on changelog fragment

Co-authored-by: Nick Gregory <nick.gregory@openenterprise.co.uk>
This commit is contained in:
NixM0nk3y 2022-01-17 17:50:19 +00:00 • committed by GitHub
parent 20d09a4ae6
commit 5540dab382
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/4043-fix-no-log-opentelemetry.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- "opentelemetry - fix generating a trace with a task containing ``no_log: true`` (https://github.com/ansible-collections/community.general/pull/4043)."

2
plugins/callback/opentelemetry.py
View file

@ -321,7 +321,7 @@ class OpenTelemetrySource(object):
# the order matters # the order matters
url_args = ("url", "api_url", "baseurl", "repo", "server_url", "chart_repo_url") url_args = ("url", "api_url", "baseurl", "repo", "server_url", "chart_repo_url")
for arg in url_args: for arg in url_args:
if args.get(arg): if args is not None and args.get(arg):
return args.get(arg) return args.get(arg)
return "" return ""