mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
Check sys.modules before loading modules
Code for a plugin is usually loaded by a PluginLoader(), and henceforth available from self._module_cache, which prevents duplicate loading. However there are situations (e.g. where one action plugin imports code from another one) where the plugin module might be already imported (and resident in sys.modules), but not present in the PluginLoader's _module_cache, which causes imp.load_source() to effectively reload the module, overwriting global class declarations and causing subtle latent bugs. Fixes #13110. Fixes #12979.
This commit is contained in:
parent
d8fb5efa90
commit
54eae4a793
1 changed files with 3 additions and 0 deletions
|
@ -304,6 +304,9 @@ class PluginLoader:
|
|||
__contains__ = has_plugin
|
||||
|
||||
def _load_module_source(self, name, path):
|
||||
if name in sys.modules:
|
||||
# See https://github.com/ansible/ansible/issues/13110
|
||||
return sys.modules[name]
|
||||
with open(path, 'r') as module_file:
|
||||
module = imp.load_source(name, path, module_file)
|
||||
return module
|
||||
|
|
Loading…
Reference in a new issue