ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Swap default for INVALID_TASK_ATTRIBUTE_FAILED to True, add additional info to exception (#44138)

Browse source
This commit is contained in:
Matt Martz 2018-08-16 16:30:47 -05:00 committed by GitHub
parent 0beaea22a4
commit 509e92ef72
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/ansible/config/base.yml
View file

@ -1385,8 +1385,8 @@ HOST_KEY_CHECKING:
type: boolean type: boolean
INVALID_TASK_ATTRIBUTE_FAILED: INVALID_TASK_ATTRIBUTE_FAILED:
name: Controls whether invalid attributes for a task result in errors instead of warnings name: Controls whether invalid attributes for a task result in errors instead of warnings
default: false default: True
description: If 'true', invalid attributes for a task will result in errors instead of warnings description: If 'false', invalid attributes for a task will result in warnings instead of errors
type: boolean type: boolean
env: env:
- name: ANSIBLE_INVALID_TASK_ATTRIBUTE_FAILED - name: ANSIBLE_INVALID_TASK_ATTRIBUTE_FAILED

7
lib/ansible/playbook/task.py
View file

@ -248,6 +248,13 @@ class Task(Base, Conditional, Taggable, Become):
return LoopControl.load(data=ds, variable_manager=self._variable_manager, loader=self._loader) return LoopControl.load(data=ds, variable_manager=self._variable_manager, loader=self._loader)
def _validate_attributes(self, ds):
try:
super(Task, self)._validate_attributes(ds)
except AnsibleParserError as e:
e.message += '\nThis error can be suppressed as a warning using the "invalid_task_attribute_failed" configuration'
raise e
def post_validate(self, templar): def post_validate(self, templar):
''' '''
Override of base class post_validate, to also do final validation on Override of base class post_validate, to also do final validation on