diff --git a/changelogs/fragments/7501-type.yml b/changelogs/fragments/7501-type.yml new file mode 100644 index 0000000000..994c31ce5a --- /dev/null +++ b/changelogs/fragments/7501-type.yml @@ -0,0 +1,2 @@ +bugfixes: + - "ocapi_utils, oci_utils, redfish_utils module utils - replace ``type()`` calls with ``isinstance()`` calls (https://github.com/ansible-collections/community.general/pull/7501)." diff --git a/plugins/module_utils/ocapi_utils.py b/plugins/module_utils/ocapi_utils.py index acc2ceae49..232c915060 100644 --- a/plugins/module_utils/ocapi_utils.py +++ b/plugins/module_utils/ocapi_utils.py @@ -432,7 +432,7 @@ class OcapiUtils(object): else: return response details = response["data"]["Status"].get("Details") - if type(details) is str: + if isinstance(details, str): details = [details] health_list = response["data"]["Status"]["Health"] return_value = { diff --git a/plugins/module_utils/oracle/oci_utils.py b/plugins/module_utils/oracle/oci_utils.py index b808d70ee2..392692e7d5 100644 --- a/plugins/module_utils/oracle/oci_utils.py +++ b/plugins/module_utils/oracle/oci_utils.py @@ -1529,7 +1529,7 @@ def delete_and_wait( result[resource_type] = resource return result # oci.wait_until() returns an instance of oci.util.Sentinel in case the resource is not found. - if type(wait_response) is not Sentinel: + if not isinstance(wait_response, Sentinel): resource = to_dict(wait_response.data) else: resource["lifecycle_state"] = "DELETED" diff --git a/plugins/module_utils/redfish_utils.py b/plugins/module_utils/redfish_utils.py index cea1fd1034..a4fc5912c4 100644 --- a/plugins/module_utils/redfish_utils.py +++ b/plugins/module_utils/redfish_utils.py @@ -3708,7 +3708,7 @@ class RedfishUtils(object): # WORKAROUND # HPE systems with iLO 4 will have BIOS Attribute Registries location URI as a dictionary with key 'extref' # Hence adding condition to fetch the Uri - if type(loc['Uri']) is dict and "extref" in loc['Uri'].keys(): + if isinstance(loc['Uri'], dict) and "extref" in loc['Uri'].keys(): rsp_uri = loc['Uri']['extref'] if not rsp_uri: msg = "Language 'en' not found in BIOS Attribute Registries location, URI: %s, response: %s"