Bug fixes for gcp_compute_backend_bucket (#42804)

lib/ansible/modules/cloud/google/gcp_compute_backend_bucket.py

@@ -74,31 +74,30 @@ options:
               be a dash.
         required: true
 extends_documentation_fragment: gcp
+notes:
+    - "API Reference: U(https://cloud.google.com/compute/docs/reference/latest/backendBuckets)"
+    - "Using a Cloud Storage bucket as a load balancer backend: U(https://cloud.google.com/compute/docs/load-balancing/http/backend-bucket)"
 '''
 
 EXAMPLES = '''
 - name: create a bucket
   gcp_storage_bucket:
-      name: 'bucket-backendbucket'
+      name: "bucket-backendbucket"
       project: "{{ gcp_project }}"
       auth_kind: "{{ gcp_cred_kind }}"
       service_account_file: "{{ gcp_cred_file }}"
-      scopes:
-        - https://www.googleapis.com/auth/devstorage.full_control
       state: present
   register: bucket
 
 - name: create a backend bucket
   gcp_compute_backend_bucket:
-      name: testObject
+      name: "test_object"
       bucket_name: "{{ bucket.name }}"
-      description: "A BackendBucket to connect LNB w/ Storage Bucket"
+      description: A BackendBucket to connect LNB w/ Storage Bucket
       enable_cdn: true
-      project: testProject
+      project: "test_project"
-      auth_kind: service_account
+      auth_kind: "service_account"
-      service_account_file: /tmp/auth.pem
+      service_account_file: "/tmp/auth.pem"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
       state: present
 '''
 
@@ -167,6 +166,9 @@ def main():
         )
     )
 
+    if not module.params['scopes']:
+        module.params['scopes'] = ['https://www.googleapis.com/auth/compute']
+
     state = module.params['state']
     kind = 'compute#backendBucket'
 
@@ -176,10 +178,10 @@ def main():
     if fetch:
         if state == 'present':
             if is_different(module, fetch):
-                fetch = update(module, self_link(module), kind, fetch)
+                fetch = update(module, self_link(module), kind)
                 changed = True
         else:
-            delete(module, self_link(module), kind, fetch)
+            delete(module, self_link(module), kind)
             fetch = {}
             changed = True
     else:
@@ -199,12 +201,12 @@ def create(module, link, kind):
     return wait_for_operation(module, auth.post(link, resource_to_request(module)))
 
 
-def update(module, link, kind, fetch):
+def update(module, link, kind):
     auth = GcpSession(module, 'compute')
     return wait_for_operation(module, auth.put(link, resource_to_request(module)))
 
 
-def delete(module, link, kind, fetch):
+def delete(module, link, kind):
     auth = GcpSession(module, 'compute')
     return wait_for_operation(module, auth.delete(link))
 
@@ -304,7 +306,7 @@ def async_op_url(module, extra_data=None):
 def wait_for_operation(module, response):
     op_result = return_if_object(module, response, 'compute#operation')
     if op_result is None:
-        return None
+        return {}
     status = navigate_hash(op_result, ['status'])
     wait_done = wait_for_completion(status, op_result, module)
     return fetch_resource(module, navigate_hash(wait_done, ['targetLink']), 'compute#backendBucket')

test/integration/targets/gcp_compute_backend_bucket/tasks/main.yml

@@ -15,38 +15,32 @@
 # Pre-test setup
 - name: create a bucket
   gcp_storage_bucket:
-      name: 'bucket-backendbucket'
+      name: "bucket-backendbucket"
       project: "{{ gcp_project }}"
       auth_kind: "{{ gcp_cred_kind }}"
       service_account_file: "{{ gcp_cred_file }}"
-      scopes:
-        - https://www.googleapis.com/auth/devstorage.full_control
       state: present
   register: bucket
 - name: delete a backend bucket
   gcp_compute_backend_bucket:
       name: "{{ resource_name }}"
       bucket_name: "{{ bucket.name }}"
-      description: "A BackendBucket to connect LNB w/ Storage Bucket"
+      description: A BackendBucket to connect LNB w/ Storage Bucket
       enable_cdn: true
       project: "{{ gcp_project }}"
       auth_kind: "{{ gcp_cred_kind }}"
       service_account_file: "{{ gcp_cred_file }}"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
       state: absent
 #----------------------------------------------------------
 - name: create a backend bucket
   gcp_compute_backend_bucket:
       name: "{{ resource_name }}"
       bucket_name: "{{ bucket.name }}"
-      description: "A BackendBucket to connect LNB w/ Storage Bucket"
+      description: A BackendBucket to connect LNB w/ Storage Bucket
       enable_cdn: true
       project: "{{ gcp_project }}"
       auth_kind: "{{ gcp_cred_kind }}"
       service_account_file: "{{ gcp_cred_file }}"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
       state: present
   register: result
 - name: assert changed is true
@@ -55,25 +49,29 @@
       - result.changed == true
       - "result.kind == 'compute#backendBucket'"
 - name: verify that backend_bucket was created
-  shell: |
+  gcp_compute_backend_bucket_facts:
-    gcloud compute backend-buckets describe  --project="{{ gcp_project}}"  "{{ resource_name }}"
+      filters:
+         - name = {{ resource_name }}
+      project: "{{ gcp_project }}"
+      auth_kind: "{{ gcp_cred_kind }}"
+      service_account_file: "{{ gcp_cred_file }}"
+      scopes:
+        - https://www.googleapis.com/auth/compute
   register: results
 - name: verify that command succeeded
   assert:
     that:
-      - results.rc == 0
+      - results['items'] | length == 1
 # ----------------------------------------------------------------------------
 - name: create a backend bucket that already exists
   gcp_compute_backend_bucket:
       name: "{{ resource_name }}"
       bucket_name: "{{ bucket.name }}"
-      description: "A BackendBucket to connect LNB w/ Storage Bucket"
+      description: A BackendBucket to connect LNB w/ Storage Bucket
       enable_cdn: true
       project: "{{ gcp_project }}"
       auth_kind: "{{ gcp_cred_kind }}"
       service_account_file: "{{ gcp_cred_file }}"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
       state: present
   register: result
 - name: assert changed is false
@@ -86,13 +84,11 @@
   gcp_compute_backend_bucket:
       name: "{{ resource_name }}"
       bucket_name: "{{ bucket.name }}"
-      description: "A BackendBucket to connect LNB w/ Storage Bucket"
+      description: A BackendBucket to connect LNB w/ Storage Bucket
       enable_cdn: true
       project: "{{ gcp_project }}"
       auth_kind: "{{ gcp_cred_kind }}"
       service_account_file: "{{ gcp_cred_file }}"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
       state: absent
   register: result
 - name: assert changed is true
@@ -101,27 +97,29 @@
       - result.changed == true
       - result.has_key('kind') == False
 - name: verify that backend_bucket was deleted
-  shell: |
+  gcp_compute_backend_bucket_facts:
-    gcloud compute backend-buckets describe  --project="{{ gcp_project}}"  "{{ resource_name }}"
+      filters:
+         - name = {{ resource_name }}
+      project: "{{ gcp_project }}"
+      auth_kind: "{{ gcp_cred_kind }}"
+      service_account_file: "{{ gcp_cred_file }}"
+      scopes:
+        - https://www.googleapis.com/auth/compute
   register: results
-  failed_when: results.rc == 0
 - name: verify that command succeeded
   assert:
     that:
-      - results.rc == 1
+      - results['items'] | length == 0
-      - "\"'projects/{{ gcp_project }}/global/backendBuckets/{{ resource_name }}' was not found\" in results.stderr"
 # ----------------------------------------------------------------------------
 - name: delete a backend bucket that does not exist
   gcp_compute_backend_bucket:
       name: "{{ resource_name }}"
       bucket_name: "{{ bucket.name }}"
-      description: "A BackendBucket to connect LNB w/ Storage Bucket"
+      description: A BackendBucket to connect LNB w/ Storage Bucket
       enable_cdn: true
       project: "{{ gcp_project }}"
       auth_kind: "{{ gcp_cred_kind }}"
       service_account_file: "{{ gcp_cred_file }}"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
       state: absent
   register: result
 - name: assert changed is false
@@ -133,11 +131,9 @@
 # Post-test teardown
 - name: delete a bucket
   gcp_storage_bucket:
-      name: 'bucket-backendbucket'
+      name: "bucket-backendbucket"
       project: "{{ gcp_project }}"
       auth_kind: "{{ gcp_cred_kind }}"
       service_account_file: "{{ gcp_cred_file }}"
-      scopes:
-        - https://www.googleapis.com/auth/devstorage.full_control
       state: absent
   register: bucket