ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

fix error when cache is disabled (#2518)

Browse source
This commit is contained in:
Dennis Israelsson 2021-05-17 07:35:15 +02:00 committed by GitHub
parent ea200c9d8c
commit 448b8cbcda
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/2518-nmap-fix-cache-disabled.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- nmap inventory plugin - fix local variable error when cache is disabled (https://github.com/ansible-collections/community.general/issues/2512).

3
plugins/inventory/nmap.py
View file

@ -130,7 +130,7 @@ class InventoryModule(BaseInventoryPlugin, Constructable, Cacheable):
# This occurs if the cache_key is not in the cache or if the cache_key expired, so the cache needs to be updated # This occurs if the cache_key is not in the cache or if the cache_key expired, so the cache needs to be updated
cache_needs_update = True cache_needs_update = True
if cache_needs_update: if not user_cache_setting or cache_needs_update:
# setup command # setup command
cmd = [self._nmap] cmd = [self._nmap]
if not self._options['ports']: if not self._options['ports']:
@ -207,6 +207,7 @@ class InventoryModule(BaseInventoryPlugin, Constructable, Cacheable):
except Exception as e: except Exception as e:
raise AnsibleParserError("failed to parse %s: %s " % (to_native(path), to_native(e))) raise AnsibleParserError("failed to parse %s: %s " % (to_native(path), to_native(e)))
if cache_needs_update:
self._cache[cache_key] = results self._cache[cache_key] = results
self._populate(results) self._populate(results)