Properly parse JSON Lines output from yarn (#4050)

* Properly parse JSON Lines output from yarn

* Properly support output of yarn global list

* Add changelog fragment

* Check that the string starts with 'bins-'

* Fix changelog fragment

* Update changelogs/fragments/4050-properly-parse-json-lines-output-from-yarn.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>

changelogs/fragments/4050-properly-parse-json-lines-output-from-yarn.yaml

@@ -0,0 +1,3 @@
+bugfixes:
+  - yarn - fix incorrect handling of ``yarn list`` and ``yarn global list`` output that could result in fatal error (https://github.com/ansible-collections/community.general/pull/4050).
+  - yarn - fix incorrectly reported status when installing a package globally (https://github.com/ansible-collections/community.general/issues/4045, https://github.com/ansible-collections/community.general/pull/4050).

plugins/modules/packaging/language/yarn.py

@@ -241,16 +241,19 @@ class Yarn(object):
         if error:
             self.module.fail_json(msg=error)
 
-        data = json.loads(result)
+        for json_line in result.strip().split('\n'):
-        try:
+            data = json.loads(json_line)
-            dependencies = data['data']['trees']
+            if self.globally:
-        except KeyError:
+                if data['type'] == 'list' and data['data']['type'].startswith('bins-'):
-            missing.append(self.name)
+                    # This is a string in format: 'bins-<PACKAGE_NAME>'
-            return installed, missing
+                    installed.append(data['data']['type'][5:])
+            else:
+                if data['type'] == 'tree':
+                    dependencies = data['data']['trees']
 
-        for dep in dependencies:
+                    for dep in dependencies:
-            name, version = dep['name'].rsplit('@', 1)
+                        name, version = dep['name'].rsplit('@', 1)
-            installed.append(name)
+                        installed.append(name)
 
         if self.name not in installed:
             missing.append(self.name)