From 405d6d605f7f1186a4f9fc4148c8464a8f965802 Mon Sep 17 00:00:00 2001
From: Ryan Brown <sb@ryansb.com>
Date: Wed, 14 Nov 2018 11:40:38 -0500
Subject: [PATCH] [AWS] Enable Route53 integration tests (#46228)

---
 test/integration/targets/route53/aliases      |  2 +-
 .../targets/route53/tasks/main.yml            | 68 +++++++++++++++++--
 2 files changed, 64 insertions(+), 6 deletions(-)

diff --git a/test/integration/targets/route53/aliases b/test/integration/targets/route53/aliases
index 5692719518..a112c3d1bb 100644
--- a/test/integration/targets/route53/aliases
+++ b/test/integration/targets/route53/aliases
@@ -1,2 +1,2 @@
 cloud/aws
-unsupported
+shippable/aws/group1
diff --git a/test/integration/targets/route53/tasks/main.yml b/test/integration/targets/route53/tasks/main.yml
index fd821c1ab7..d8076a1bd1 100644
--- a/test/integration/targets/route53/tasks/main.yml
+++ b/test/integration/targets/route53/tasks/main.yml
@@ -1,5 +1,5 @@
 ---
-# tasks file for Route53
+# tasks file for Route53 integration tests
 
 - set_fact:
     zone_one: '{{ resource_prefix | replace("-", "") }}.one.fakeansible.com.'
@@ -50,6 +50,68 @@
         - non_qdn is not failed
         - non_qdn is not changed
 
+  - name: Create a multi-value A record with values in different order
+    route53:
+      state: present
+      zone: '{{ zone_one }}'
+      record: 'order_test.{{ zone_one }}'
+      type: A
+      value:
+        - 4.5.6.7
+        - 1.2.3.4
+    register: mv_a_record
+  - assert:
+      that:
+        - mv_a_record is not failed
+        - mv_a_record is changed
+
+  - name: Create same multi-value A record with values in different order
+    route53:
+      state: present
+      zone: '{{ zone_one }}'
+      record: 'order_test.{{ zone_one }}'
+      type: A
+      value:
+        - 4.5.6.7
+        - 1.2.3.4
+    register: mv_a_record
+  - assert:
+      that:
+        - mv_a_record is not failed
+        - mv_a_record is not changed
+
+  - name: Remove a member from multi-value A record with values in different order
+    route53:
+      state: present
+      zone: '{{ zone_one }}'
+      record: 'order_test.{{ zone_one }}'
+      type: A
+      value:
+        - 4.5.6.7
+    register: del_a_record
+    ignore_errors: true
+  - name: This should fail, because `overwrite` is false
+    assert:
+      that:
+        - del_a_record is failed
+
+  - name: Remove a member from multi-value A record with values in different order
+    route53:
+      state: present
+      zone: '{{ zone_one }}'
+      record: 'order_test.{{ zone_one }}'
+      overwrite: true
+      type: A
+      value:
+        - 4.5.6.7
+    register: del_a_record
+    ignore_errors: true
+  - name: This should fail, because `overwrite` is false
+    assert:
+      that:
+        - del_a_record is not failed
+        - del_a_record is changed
+
   - name: Create a LetsEncrypt CAA record
     route53:
       state: present
@@ -129,7 +191,3 @@
     retries: 10
     until: delete_two is not failed
     when: false
-
-
-#TODO(ryansb) build internal-vpc integration tests
-#- include_tasks: internal_zone.yml