From 3ee3fc893d3aa6e8890f30397a7a0304933d0eb6 Mon Sep 17 00:00:00 2001 From: Kevin Breit Date: Mon, 2 Jul 2018 21:20:36 -0500 Subject: [PATCH] Change idempotency check to be single pass (#42087) - Previously all data between both data structures was compared - Results in situations where updates are done when not needed - Changes to single pass so only data in payload is compared --- .../module_utils/network/meraki/meraki.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/ansible/module_utils/network/meraki/meraki.py b/lib/ansible/module_utils/network/meraki/meraki.py index 09423ab312..7a9178c5f8 100644 --- a/lib/ansible/module_utils/network/meraki/meraki.py +++ b/lib/ansible/module_utils/network/meraki/meraki.py @@ -130,14 +130,14 @@ class MerakiModule(object): if not optional_ignore: optional_ignore = ('') - for k, v in original.items(): - try: - if k not in ignored_keys and k not in optional_ignore: - if v != proposed[k]: - is_changed = True - except KeyError: - if v != '': - is_changed = True + # for k, v in original.items(): + # try: + # if k not in ignored_keys and k not in optional_ignore: + # if v != proposed[k]: + # is_changed = True + # except KeyError: + # if v != '': + # is_changed = True for k, v in proposed.items(): try: if k not in ignored_keys and k not in optional_ignore: