ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

dig lookup: fix DNSKEY's algorithm handling (#5914)

Browse source 
Fix DNSKEY's algorithm handling.
This commit is contained in:
Felix Fontein 2023-01-29 18:18:27 +01:00 committed by GitHub
parent 6c6de8fb90
commit 3da24d50cd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/5914-dig-dnskey.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- "dig lookup plugin - correctly handle DNSKEY record type's ``algorithm`` field (https://github.com/ansible-collections/community.general/pull/5914)."

4
plugins/lookup/dig.py
View file

@ -230,7 +230,7 @@ def make_rdata_dict(rdata):
NSEC3PARAM: ['algorithm', 'flags', 'iterations', 'salt'], NSEC3PARAM: ['algorithm', 'flags', 'iterations', 'salt'],
PTR: ['target'], PTR: ['target'],
RP: ['mbox', 'txt'], RP: ['mbox', 'txt'],
# RRSIG: ['algorithm', 'labels', 'original_ttl', 'expiration', 'inception', 'signature'], # RRSIG: ['type_covered', 'algorithm', 'labels', 'original_ttl', 'expiration', 'inception', 'key_tag', 'signer', 'signature'],
SOA: ['mname', 'rname', 'serial', 'refresh', 'retry', 'expire', 'minimum'], SOA: ['mname', 'rname', 'serial', 'refresh', 'retry', 'expire', 'minimum'],
SPF: ['strings'], SPF: ['strings'],
SRV: ['priority', 'weight', 'port', 'target'], SRV: ['priority', 'weight', 'port', 'target'],
@ -251,6 +251,8 @@ def make_rdata_dict(rdata):
if rdata.rdtype == DS and f == 'digest': if rdata.rdtype == DS and f == 'digest':
val = dns.rdata._hexify(rdata.digest).replace(' ', '') val = dns.rdata._hexify(rdata.digest).replace(' ', '')
if rdata.rdtype == DNSKEY and f == 'algorithm':
val = int(val)
if rdata.rdtype == DNSKEY and f == 'key': if rdata.rdtype == DNSKEY and f == 'key':
val = dns.rdata._base64ify(rdata.key).replace(' ', '') val = dns.rdata._base64ify(rdata.key).replace(' ', '')
if rdata.rdtype == NSEC3PARAM and f == 'salt': if rdata.rdtype == NSEC3PARAM and f == 'salt':