From 399c28c11efe1987d30f7f9c4f0820b191ac6bae Mon Sep 17 00:00:00 2001 From: "patchback[bot]" <45432694+patchback[bot]@users.noreply.github.com> Date: Thu, 5 Nov 2020 06:49:07 +0100 Subject: [PATCH] proxmox_template download appliance templates (#1046) (#1230) * proxmox_template download appliance templates * Update changelogs/fragments/proxmox_template-appliance-download.yml added pull request link Co-authored-by: Felix Fontein * Update plugins/modules/cloud/misc/proxmox_template.py Co-authored-by: Felix Fontein * Update plugins/modules/cloud/misc/proxmox_template.py Co-authored-by: Tristan Le Guern * Update proxmox_template.py grammar * removed debug message Co-authored-by: Tobias Lindenberg Co-authored-by: Felix Fontein Co-authored-by: Tristan Le Guern (cherry picked from commit 890ff574c3b7d8530c372addfc98a718f8e4c419) Co-authored-by: Tobias Lindenberg --- .../proxmox_template-appliance-download.yml | 3 ++ .../modules/cloud/misc/proxmox_template.py | 52 ++++++++++++++++--- 2 files changed, 47 insertions(+), 8 deletions(-) create mode 100644 changelogs/fragments/proxmox_template-appliance-download.yml diff --git a/changelogs/fragments/proxmox_template-appliance-download.yml b/changelogs/fragments/proxmox_template-appliance-download.yml new file mode 100644 index 0000000000..cbeadad0e4 --- /dev/null +++ b/changelogs/fragments/proxmox_template-appliance-download.yml @@ -0,0 +1,3 @@ +--- +minor_changes: + - proxmox_template - download proxmox applicance templates (pveam) (https://github.com/ansible-collections/community.general/pull/1046). diff --git a/plugins/modules/cloud/misc/proxmox_template.py b/plugins/modules/cloud/misc/proxmox_template.py index 5b0af9dfbe..631102a212 100644 --- a/plugins/modules/cloud/misc/proxmox_template.py +++ b/plugins/modules/cloud/misc/proxmox_template.py @@ -48,7 +48,8 @@ options: template: description: - the template name - - required only for states C(absent), C(info) + - Required for state C(absent) to delete a template. + - Required for state C(present) to download an appliance container template (pveam). type: str content_type: description: @@ -121,6 +122,16 @@ EXAMPLES = ''' api_host: node1 template: ubuntu-14.04-x86_64.tar.gz state: absent + +- name: Download proxmox appliance container template + community.general.proxmox_template: + node: uk-mc02 + api_user: root@pam + api_password: 1q2w3e + api_host: node1 + storage: local + content_type: vztmpl + template: ubuntu-20.04-standard_20.04-1_amd64.tar.gz ''' import os @@ -140,21 +151,33 @@ def get_template(proxmox, node, storage, content_type, template): if tmpl['volid'] == '%s:%s/%s' % (storage, content_type, template)] -def upload_template(module, proxmox, api_host, node, storage, content_type, realpath, timeout): - taskid = proxmox.nodes(node).storage(storage).upload.post(content=content_type, filename=open(realpath, 'rb')) +def task_status(module, proxmox, node, taskid, timeout): + """ + Check the task status and wait until the task is completed or the timeout is reached. + """ while timeout: - task_status = proxmox.nodes(api_host.split('.')[0]).tasks(taskid).status.get() + task_status = proxmox.nodes(node).tasks(taskid).status.get() if task_status['status'] == 'stopped' and task_status['exitstatus'] == 'OK': return True timeout = timeout - 1 if timeout == 0: - module.fail_json(msg='Reached timeout while waiting for uploading template. Last line in task before timeout: %s' - % proxmox.node(node).tasks(taskid).log.get()[:1]) + module.fail_json(msg='Reached timeout while waiting for uploading/downloading template. Last line in task before timeout: %s' + % proxmox.node(node).tasks(taskid).log.get()[:1]) time.sleep(1) return False +def upload_template(module, proxmox, node, storage, content_type, realpath, timeout): + taskid = proxmox.nodes(node).storage(storage).upload.post(content=content_type, filename=open(realpath, 'rb')) + return task_status(module, proxmox, node, taskid, timeout) + + +def download_template(module, proxmox, node, storage, template, timeout): + taskid = proxmox.nodes(node).aplinfo.post(storage=storage, template=template) + return task_status(module, proxmox, node, taskid, timeout) + + def delete_template(module, proxmox, node, storage, content_type, template, timeout): volid = '%s:%s/%s' % (storage, content_type, template) proxmox.nodes(node).storage(storage).content.delete(volid) @@ -216,6 +239,19 @@ def main(): content_type = module.params['content_type'] src = module.params['src'] + # download appliance template + if content_type == 'vztmpl' and not src: + template = module.params['template'] + + if not template: + module.fail_json(msg='template param for downloading appliance template is mandatory') + + if get_template(proxmox, node, storage, content_type, template) and not module.params['force']: + module.exit_json(changed=False, msg='template with volid=%s:%s/%s already exists' % (storage, content_type, template)) + + if download_template(module, proxmox, node, storage, template, timeout): + module.exit_json(changed=True, msg='template with volid=%s:%s/%s downloaded' % (storage, content_type, template)) + template = os.path.basename(src) if get_template(proxmox, node, storage, content_type, template) and not module.params['force']: module.exit_json(changed=False, msg='template with volid=%s:%s/%s is already exists' % (storage, content_type, template)) @@ -224,10 +260,10 @@ def main(): elif not (os.path.exists(src) and os.path.isfile(src)): module.fail_json(msg='template file on path %s not exists' % src) - if upload_template(module, proxmox, api_host, node, storage, content_type, src, timeout): + if upload_template(module, proxmox, node, storage, content_type, src, timeout): module.exit_json(changed=True, msg='template with volid=%s:%s/%s uploaded' % (storage, content_type, template)) except Exception as e: - module.fail_json(msg="uploading of template %s failed with exception: %s" % (template, e)) + module.fail_json(msg="uploading/downloading of template %s failed with exception: %s" % (template, e)) elif state == 'absent': try: