ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Return early from setup step when possible

Browse source 
The _list_available_hosts call can be lengthy, and in the case where
gather_facts is disabled the call is pointless. So re-arrange the logic
to return early from _do_setup_step when gather_facts is false.
This commit is contained in:
Jesse Keating 2014-01-03 16:39:13 -08:00
parent 191be7b951
commit 35328ed503
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/ansible/playbook/__init__.py
View file

@ -433,11 +433,11 @@ class PlayBook(object):
def _do_setup_step(self, play): def _do_setup_step(self, play):
''' get facts from the remote system ''' ''' get facts from the remote system '''
host_list = self._list_available_hosts(play.hosts)
if play.gather_facts is False: if play.gather_facts is False:
return {} return {}
elif play.gather_facts is None:
host_list = self._list_available_hosts(play.hosts)
if play.gather_facts is None:
host_list = [h for h in host_list if h not in self.SETUP_CACHE or 'module_setup' not in self.SETUP_CACHE[h]] host_list = [h for h in host_list if h not in self.SETUP_CACHE or 'module_setup' not in self.SETUP_CACHE[h]]
if len(host_list) == 0: if len(host_list) == 0:
return {} return {}