1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00

Actual attributes were being created and messing with the modules (#22424)

This commit is contained in:
Tim Rupp 2017-03-08 13:10:02 -08:00 committed by John R Barker
parent 78e116077a
commit 32146acf4e

View file

@ -288,26 +288,26 @@ class AnsibleF5Parameters(object):
if params:
for k,v in iteritems(params):
if self.api_map is not None and k in self.api_map:
# Handle weird API parameters like `dns.proxy.__iter__` by
# using a map provided by the module developer
class_attr = getattr(type(self), self.api_map[k], None)
if isinstance(class_attr, property):
# There is a mapped value for the api_map key
if class_attr.fset is None:
# If the mapped value does not have an associated setter
self._values[self.api_map[k]] = v
else:
# The mapped value has a setter
setattr(self, self.api_map[k], v)
dict_to_use = self.api_map
map_key = self.api_map[k]
else:
dict_to_use = self._values
map_key = k
# Handle weird API parameters like `dns.proxy.__iter__` by
# using a map provided by the module developer
class_attr = getattr(type(self), map_key, None)
if isinstance(class_attr, property):
# There is a mapped value for the api_map key
if class_attr.fset is None:
# If the mapped value does not have an associated setter
self._values[map_key] = v
else:
# If the mapped value is not a @property
self._values[self.api_map[k]] = v
try:
# There is no map, or the provided param is not in the api_map
setattr(self, k, v)
except AttributeError:
# At a minimum put it in values.
self._values[k] = v
# The mapped value has a setter
setattr(self, map_key, v)
else:
# If the mapped value is not a @property
self._values[map_key] = v
def __getattr__(self, item):
# Ensures that properties that weren't defined, and therefore stashed