mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
If package installation has an error after the package is install (e.g.
when running tags), then there will be output on stderr and the fallback
regex will match; however, since pkg_add exited non-zero, changed is
never added as a key to the dictionary. As a result the code at the end
of main that checks if anything has changed raises a KeyError.
(cherry picked from commit 02d0e3d286
)
Co-authored-by: Matthew Martin <phy1729@gmail.com>
This commit is contained in:
parent
34b7876e4f
commit
314a0bc553
2 changed files with 6 additions and 0 deletions
5
changelogs/fragments/3336-openbsd_pkg-fix-KeyError.yml
Normal file
5
changelogs/fragments/3336-openbsd_pkg-fix-KeyError.yml
Normal file
|
@ -0,0 +1,5 @@
|
|||
---
|
||||
bugfixes:
|
||||
- openbsd_pkg - fix crash from ``KeyError`` exception when package installs,
|
||||
but ``pkg_add`` returns with a non-zero exit code
|
||||
(https://github.com/ansible-collections/community.general/pull/3336).
|
|
@ -246,6 +246,7 @@ def package_present(names, pkg_spec, module):
|
|||
if match:
|
||||
# It turns out we were able to install the package.
|
||||
module.debug("package_present(): we were able to install package for name '%s'" % name)
|
||||
pkg_spec[name]['changed'] = True
|
||||
else:
|
||||
# We really did fail, fake the return code.
|
||||
module.debug("package_present(): we really did fail for name '%s'" % name)
|
||||
|
|
Loading…
Reference in a new issue