ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

openbsd_pkg: Fix KeyError (#3336) (#3407)

Browse source 
If package installation has an error after the package is install (e.g.
when running tags), then there will be output on stderr and the fallback
regex will match; however, since pkg_add exited non-zero, changed is
never added as a key to the dictionary. As a result the code at the end
of main that checks if anything has changed raises a KeyError.

(cherry picked from commit 02d0e3d286)

Co-authored-by: Matthew Martin <phy1729@gmail.com>
This commit is contained in:
patchback[bot] 2021-09-20 19:49:52 +02:00 committed by GitHub
parent 34b7876e4f
commit 314a0bc553
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
changelogs/fragments/3336-openbsd_pkg-fix-KeyError.yml Normal file
View file

@ -0,0 +1,5 @@
---
bugfixes:
- openbsd_pkg - fix crash from ``KeyError`` exception when package installs,
but ``pkg_add`` returns with a non-zero exit code
(https://github.com/ansible-collections/community.general/pull/3336).

1
plugins/modules/packaging/os/openbsd_pkg.py
View file

@ -246,6 +246,7 @@ def package_present(names, pkg_spec, module):
if match: if match:
# It turns out we were able to install the package. # It turns out we were able to install the package.
module.debug("package_present(): we were able to install package for name '%s'" % name) module.debug("package_present(): we were able to install package for name '%s'" % name)
pkg_spec[name]['changed'] = True
else: else:
# We really did fail, fake the return code. # We really did fail, fake the return code.
module.debug("package_present(): we really did fail for name '%s'" % name) module.debug("package_present(): we really did fail for name '%s'" % name)