ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

win_chocolatey: always return the rc return value (#41883)

Browse source
This commit is contained in:
Jordan Borean 2018-06-25 08:23:31 +10:00 committed by GitHub
parent f30e0b833d
commit 2e46688bca
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/win_chocolatey-return-rc-always.yml Normal file
View file

@ -0,0 +1,2 @@
minor_changes:
- win_chocolatey - set the rc return value to always be returned, default to 0 https://github.com/ansible/ansible/issues/41758

1
lib/ansible/modules/windows/win_chocolatey.ps1
View file

@ -36,6 +36,7 @@ $proxy_password = Get-AnsibleParam -obj $params -name "proxy_password" -type "st
$result = @{ $result = @{
changed = $false changed = $false
rc = 0
} }
Function Chocolatey-Install-Upgrade Function Chocolatey-Install-Upgrade

2
lib/ansible/modules/windows/win_chocolatey.py
View file

@ -211,7 +211,7 @@ command:
sample: choco.exe install -r --no-progress -y sysinternals --timeout 2700 --failonunfound sample: choco.exe install -r --no-progress -y sysinternals --timeout 2700 --failonunfound
rc: rc:
description: The return code from the chocolatey task. description: The return code from the chocolatey task.
returned: changed returned: always
type: int type: int
sample: 0 sample: 0
stdout: stdout:

4
test/integration/targets/win_chocolatey/tasks/main.yml
View file

@ -26,6 +26,7 @@
assert: assert:
that: that:
- 'install.changed == true' - 'install.changed == true'
- install.rc == 0
- name: install chocolatey-core.extension again - name: install chocolatey-core.extension again
win_chocolatey: win_chocolatey:
@ -37,6 +38,7 @@
assert: assert:
that: that:
- 'install_again.changed == false' - 'install_again.changed == false'
- install.rc == 0
- name: remove chocolatey-core.extension - name: remove chocolatey-core.extension
win_chocolatey: win_chocolatey:
@ -48,6 +50,7 @@
assert: assert:
that: that:
- 'remove.changed == true' - 'remove.changed == true'
- install.rc == 0
- name: remove chocolatey-core.extension again - name: remove chocolatey-core.extension again
win_chocolatey: win_chocolatey:
@ -59,3 +62,4 @@
assert: assert:
that: that:
- 'remove_again.changed == false' - 'remove_again.changed == false'
- install.rc == 0