From 2a4bf670bb1bf43ed02453cfdcd147e7cce398e7 Mon Sep 17 00:00:00 2001 From: Zim Kalinowski Date: Mon, 1 Oct 2018 15:39:40 -0700 Subject: [PATCH] clean up doc - removed required: false (#46357) --- lib/ansible/modules/cloud/azure/azure_rm_acs.py | 9 ++------- .../modules/cloud/azure/azure_rm_appgateway.py | 1 - .../cloud/azure/azure_rm_availabilityset.py | 16 +++------------- .../modules/cloud/azure/azure_rm_functionapp.py | 4 +--- .../modules/cloud/azure/azure_rm_keyvaultkey.py | 1 - .../cloud/azure/azure_rm_keyvaultsecret.py | 2 -- .../modules/cloud/azure/azure_rm_loadbalancer.py | 15 --------------- 7 files changed, 6 insertions(+), 42 deletions(-) diff --git a/lib/ansible/modules/cloud/azure/azure_rm_acs.py b/lib/ansible/modules/cloud/azure/azure_rm_acs.py index 0c811512df..aa1525ff29 100644 --- a/lib/ansible/modules/cloud/azure/azure_rm_acs.py +++ b/lib/ansible/modules/cloud/azure/azure_rm_acs.py @@ -110,11 +110,9 @@ options: client_id: description: - The ID for the Service Principal. - required: false client_secret: description: - The secret password associated with the service principal. - required: false diagnostics_profile: description: - Should VM Diagnostics be enabled for the Container Service VM's. @@ -469,13 +467,11 @@ class AzureRMContainerService(AzureRMModuleBase): ), state=dict( type='str', - required=False, default='present', choices=['present', 'absent'] ), location=dict( - type='str', - required=False + type='str' ), orchestration_platform=dict( type='str', @@ -495,8 +491,7 @@ class AzureRMContainerService(AzureRMModuleBase): required=True ), service_principal=dict( - type='list', - required=False + type='list' ), diagnostics_profile=dict( type='bool', diff --git a/lib/ansible/modules/cloud/azure/azure_rm_appgateway.py b/lib/ansible/modules/cloud/azure/azure_rm_appgateway.py index 0368f355b2..2d155d0b5f 100644 --- a/lib/ansible/modules/cloud/azure/azure_rm_appgateway.py +++ b/lib/ansible/modules/cloud/azure/azure_rm_appgateway.py @@ -303,7 +303,6 @@ options: choices: - absent - present - required: false extends_documentation_fragment: - azure diff --git a/lib/ansible/modules/cloud/azure/azure_rm_availabilityset.py b/lib/ansible/modules/cloud/azure/azure_rm_availabilityset.py index f931f08792..708caf55e8 100644 --- a/lib/ansible/modules/cloud/azure/azure_rm_availabilityset.py +++ b/lib/ansible/modules/cloud/azure/azure_rm_availabilityset.py @@ -41,21 +41,17 @@ options: choices: - absent - present - required: false location: description: - Valid azure location. Defaults to location of the resource group. - required: false platform_update_domain_count: description: - Update domains indicate groups of virtual machines and underlying physical hardware that can be rebooted at the same time. Default is 5. default: 5 - required: false platform_fault_domain_count: description: - Fault domains define the group of virtual machines that share a common power source and network switch. Should be between 1 and 3. Default is 3 default: 3 - required: false sku: description: - Define if the availability set supports managed disks. @@ -63,7 +59,6 @@ options: choices: - Classic - Aligned - required: false extends_documentation_fragment: - azure - azure_tags @@ -147,28 +142,23 @@ class AzureRMAvailabilitySet(AzureRMModuleBase): ), state=dict( type='str', - required=False, default='present', choices=['present', 'absent'] ), location=dict( - type='str', - required=False + type='str' ), platform_update_domain_count=dict( type='int', - default=5, - required=False + default=5 ), platform_fault_domain_count=dict( type='int', - default=3, - required=False + default=3 ), sku=dict( type='str', default='Classic', - required=False, choices=['Classic', 'Aligned'] ) ) diff --git a/lib/ansible/modules/cloud/azure/azure_rm_functionapp.py b/lib/ansible/modules/cloud/azure/azure_rm_functionapp.py index 0432bb110d..343d00dc46 100644 --- a/lib/ansible/modules/cloud/azure/azure_rm_functionapp.py +++ b/lib/ansible/modules/cloud/azure/azure_rm_functionapp.py @@ -48,7 +48,6 @@ options: description: - Assert the state of the Function App. Use 'present' to create or update a Function App and 'absent' to delete. - required: false default: present choices: - absent @@ -143,10 +142,9 @@ class AzureRMFunctionApp(AzureRMModuleBase): resource_group=dict(type='str', required=True, aliases=['resource_group_name']), name=dict(type='str', required=True), state=dict(type='str', default='present', choices=['present', 'absent']), - location=dict(type='str', required=False), + location=dict(type='str'), storage_account=dict( type='str', - required=False, aliases=['storage', 'storage_account_name'] ), app_settings=dict(type='dict') diff --git a/lib/ansible/modules/cloud/azure/azure_rm_keyvaultkey.py b/lib/ansible/modules/cloud/azure/azure_rm_keyvaultkey.py index 2edcdb9d71..2f9137096d 100644 --- a/lib/ansible/modules/cloud/azure/azure_rm_keyvaultkey.py +++ b/lib/ansible/modules/cloud/azure/azure_rm_keyvaultkey.py @@ -41,7 +41,6 @@ options: description: - Assert the state of the key. Use 'present' to create a key and 'absent' to delete a key. - required: false default: present choices: - absent diff --git a/lib/ansible/modules/cloud/azure/azure_rm_keyvaultsecret.py b/lib/ansible/modules/cloud/azure/azure_rm_keyvaultsecret.py index 8401ecccf5..60d269f9e8 100644 --- a/lib/ansible/modules/cloud/azure/azure_rm_keyvaultsecret.py +++ b/lib/ansible/modules/cloud/azure/azure_rm_keyvaultsecret.py @@ -31,12 +31,10 @@ options: secret_value: description: - Secret to be secured by keyvault. - required: false state: description: - Assert the state of the subnet. Use 'present' to create or update a secret and 'absent' to delete a secret . - required: false default: present choices: - absent diff --git a/lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py b/lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py index 3fa04c6e3d..a3af9f647c 100644 --- a/lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py +++ b/lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py @@ -212,17 +212,14 @@ options: - public_ip_address - public_ip_name - public_ip - required: false probe_port: description: - (deprecated) The port that the health probe will use. - This option has been deprecated, and will be removed in 2.9. Use I(probes) instead. - required: false probe_protocol: description: - (deprecated) The protocol to use for the health probe. - This option has been deprecated, and will be removed in 2.9. Use I(probes) instead. - required: false choices: - Tcp - Http @@ -231,23 +228,19 @@ options: - (deprecated) Time (in seconds) between endpoint health probes. - This option has been deprecated, and will be removed in 2.9. Use I(probes) instead. default: 15 - required: false probe_fail_count: description: - (deprecated) The amount of probe failures for the load balancer to make a health determination. - This option has been deprecated, and will be removed in 2.9. Use I(probes) instead. default: 3 - required: false probe_request_path: description: - (deprecated) The URL that an HTTP probe will use (only relevant if probe_protocol is set to Http). - This option has been deprecated, and will be removed in 2.9. Use I(probes) instead. - required: false protocol: description: - (deprecated) The protocol (TCP or UDP) that the load balancer will use. - This option has been deprecated, and will be removed in 2.9. Use I(load_balancing_rules) instead. - required: false choices: - Tcp - Udp @@ -255,7 +248,6 @@ options: description: - (deprecated) The type of load distribution that the load balancer will employ. - This option has been deprecated, and will be removed in 2.9. Use I(load_balancing_rules) instead. - required: false choices: - Default - SourceIP @@ -264,38 +256,31 @@ options: description: - (deprecated) Frontend port that will be exposed for the load balancer. - This option has been deprecated, and will be removed in 2.9. Use I(load_balancing_rules) instead. - required: false backend_port: description: - (deprecated) Backend port that will be exposed for the load balancer. - This option has been deprecated, and will be removed in 2.9. Use I(load_balancing_rules) instead. - required: false idle_timeout: description: - (deprecated) Timeout for TCP idle connection in minutes. - This option has been deprecated, and will be removed in 2.9. Use I(load_balancing_rules) instead. default: 4 - required: false natpool_frontend_port_start: description: - (deprecated) Start of the port range for a NAT pool. - This option has been deprecated, and will be removed in 2.9. Use I(inbound_nat_pools) instead. - required: false natpool_frontend_port_end: description: - (deprecated) End of the port range for a NAT pool. - This option has been deprecated, and will be removed in 2.9. Use I(inbound_nat_pools) instead. - required: false natpool_backend_port: description: - (deprecated) Backend port used by the NAT pool. - This option has been deprecated, and will be removed in 2.9. Use I(inbound_nat_pools) instead. - required: false natpool_protocol: description: - (deprecated) The protocol for the NAT pool. - This option has been deprecated, and will be removed in 2.9. Use I(inbound_nat_pools) instead. - required: false extends_documentation_fragment: - azure - azure_tags