ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

fix error checking if netns exists (#47397)

Browse source 
This patch fixes an error that occurs when attempting to see if the
netns already exists on the remote device.  This change will now execute
`ip netns list` and check if the desired namespace is in the output.

Signed-off-by: Peter Sprygada <psprygada@ansible.com>
This commit is contained in:
Peter Sprygada 2018-10-22 12:58:48 -05:00 committed by Nathaniel Case
parent a66d5ccf03
commit 299a5e4af3
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/ansible/modules/net_tools/ip_netns.py
View file

@ -61,6 +61,7 @@ RETURN = '''
''' '''
from ansible.module_utils.basic import AnsibleModule from ansible.module_utils.basic import AnsibleModule
from ansible.module_utils._text import to_text
class Namespace(object): class Namespace(object):
@ -77,9 +78,10 @@ class Namespace(object):
def exists(self): def exists(self):
'''Check if the namespace already exists''' '''Check if the namespace already exists'''
rtc, out, err = self._netns(['exec', self.name, 'ls']) rc, out, err = self.module.run_command('ip netns list')
if rtc != 0: if rc != 0:
self.module.fail_json(msg=err) self.module.fail_json(msg=to_text(err))
return self.name in out
def add(self): def add(self):
'''Create network namespace''' '''Create network namespace'''