Update ansible-logstash-callback (#641)

* Update version of callback/logstash.py

* ansible-logstash-callback rollback version_added location

* Update plugins/callback/logstash.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/callback/logstash.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/641-update-ansible-logstash-callback.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>

changelogs/fragments/641-update-ansible-logstash-callback.yml

@@ -0,0 +1,3 @@
+minor_changes:
+- logstash callback - migrate to python3-logstash (https://github.com/ansible-collections/community.general/pull/641).
+- logstash callback - improve logstash message structure, needs to be enabled with the ``format_version`` option (https://github.com/ansible-collections/community.general/pull/641).

plugins/callback/logstash.py

@@ -1,12 +1,12 @@
-# (C) 2016, Ievgen Khmelenko <ujenmr@gmail.com>
+# (C) 2020, Yevhen Khmelenko <ujenmr@gmail.com>
 # (C) 2017 Ansible Project
 # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 
 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 
-DOCUMENTATION = '''
+DOCUMENTATION = r'''
-    author: Unknown (!UNKNOWN)
+    author: Yevhen Khmelenko (@ujenmr)
     name: logstash
     type: notification
     short_description: Sends events to Logstash
@@ -43,15 +43,60 @@ DOCUMENTATION = '''
             key: type
             version_added: 1.0.0
         default: ansible
+      pre_command:
+        description: Executes command before run and result put to ansible_pre_command_output field.
+        version_added: 2.0.0
+        ini:
+          - section: callback_logstash
+            key: pre_command
+        env:
+          - name: LOGSTASH_PRE_COMMAND
+      format_version:
+        description: Logging format
+        type: str
+        version_added: 2.0.0
+        ini:
+          - section: callback_logstash
+            key: format_version
+        env:
+          - name: LOGSTASH_FORMAT_VERSION
+        default: v1
+        choices:
+          - v1
+          - v2
+
+'''
+
+EXAMPLES = r'''
+ansible.cfg: |
+    # Enable Callback plugin
+    [defaults]
+        callback_whitelist = community.general.logstash
+
+    [callback_logstash]
+        server = logstash.example.com
+        port = 5000
+        pre_command = git rev-parse HEAD
+        type = ansible
+
+11-input-tcp.conf: |
+    # Enable Logstash TCP Input
+    input {
+            tcp {
+                port => 5000
+                codec => json
+                add_field => { "[@metadata][beat]" => "notify" }
+                add_field => { "[@metadata][type]" => "ansible" }
+            }
+        }
 '''
 
 import os
 import json
 import socket
 import uuid
-from datetime import datetime
-
 import logging
+from datetime import datetime
 
 try:
     import logstash
@@ -63,75 +108,77 @@ from ansible.plugins.callback import CallbackBase
 
 
 class CallbackModule(CallbackBase):
-    """
-    ansible logstash callback plugin
-    ansible.cfg:
-        callback_plugins   = <path_to_callback_plugins_folder>
-        callback_whitelist = logstash
-    and put the plugin in <path_to_callback_plugins_folder>
-
-    logstash config:
-        input {
-            tcp {
-                port => 5000
-                codec => json
-            }
-        }
-
-    Requires:
-        python-logstash
-
-    This plugin makes use of the following environment variables or ini config:
-        LOGSTASH_SERVER   (optional): defaults to localhost
-        LOGSTASH_PORT     (optional): defaults to 5000
-        LOGSTASH_TYPE     (optional): defaults to ansible
-    """
 
     CALLBACK_VERSION = 2.0
     CALLBACK_TYPE = 'aggregate'
     CALLBACK_NAME = 'community.general.logstash'
     CALLBACK_NEEDS_WHITELIST = True
 
-    def __init__(self, display=None):
+    def __init__(self):
-        super(CallbackModule, self).__init__(display=display)
+        super(CallbackModule, self).__init__()
 
         if not HAS_LOGSTASH:
             self.disabled = True
-            self._display.warning("The required python-logstash is not installed. "
+            self._display.warning("The required python-logstash/python3-logstash is not installed. "
-                                  "pip install python-logstash")
+                                  "pip install python-logstash for Python 2"
+                                  "pip install python3-logstash for Python 3")
 
         self.start_time = datetime.utcnow()
 
-    def set_options(self, task_keys=None, var_options=None, direct=None):
+    def _init_plugin(self):
-
+        if not self.disabled:
-        super(CallbackModule, self).set_options(task_keys=task_keys, var_options=var_options, direct=direct)
-
             self.logger = logging.getLogger('python-logstash-logger')
             self.logger.setLevel(logging.DEBUG)
 
-        self.logstash_server = self.get_option('server')
-        self.logstash_port = self.get_option('port')
-        self.logstash_type = self.get_option('type')
             self.handler = logstash.TCPLogstashHandler(
-            self.logstash_server,
+                self.ls_server,
-            int(self.logstash_port),
+                self.ls_port,
                 version=1,
-            message_type=self.logstash_type
+                message_type=self.ls_type
             )
+
             self.logger.addHandler(self.handler)
             self.hostname = socket.gethostname()
-        self.session = str(uuid.uuid1())
+            self.session = str(uuid.uuid4())
             self.errors = 0
 
-    def v2_playbook_on_start(self, playbook):
+            self.base_data = {
-        self.playbook = playbook._file_name
-        data = {
-            'status': "OK",
-            'host': self.hostname,
                 'session': self.session,
-            'ansible_type': "start",
+                'host': self.hostname
-            'ansible_playbook': self.playbook,
             }
+
+            if self.ls_pre_command is not None:
+                self.base_data['ansible_pre_command_output'] = os.popen(
+                    self.ls_pre_command).read()
+
+            if self._options is not None:
+                self.base_data['ansible_checkmode'] = self._options.check
+                self.base_data['ansible_tags'] = self._options.tags
+                self.base_data['ansible_skip_tags'] = self._options.skip_tags
+                self.base_data['inventory'] = self._options.inventory
+
+    def set_options(self, task_keys=None, var_options=None, direct=None):
+        super(CallbackModule, self).set_options(task_keys=task_keys, var_options=var_options, direct=direct)
+
+        self.ls_server = self.get_option('server')
+        self.ls_port = int(self.get_option('port'))
+        self.ls_type = self.get_option('type')
+        self.ls_pre_command = self.get_option('pre_command')
+        self.ls_format_version = self.get_option('format_version')
+
+        self._init_plugin()
+
+    def v2_playbook_on_start(self, playbook):
+        data = self.base_data.copy()
+        data['ansible_type'] = "start"
+        data['status'] = "OK"
+        data['ansible_playbook'] = playbook._file_name
+
+        if (self.ls_format_version == "v2"):
+            self.logger.info(
+                "START PLAYBOOK | %s", data['ansible_playbook'], extra=data
+            )
+        else:
             self.logger.info("ansible start", extra=data)
 
     def v2_playbook_on_stats(self, stats):
@@ -146,103 +193,201 @@ class CallbackModule(CallbackBase):
         else:
             status = "FAILED"
 
-        data = {
+        data = self.base_data.copy()
-            'status': status,
+        data['ansible_type'] = "finish"
-            'host': self.hostname,
+        data['status'] = status
-            'session': self.session,
+        data['ansible_playbook_duration'] = runtime.total_seconds()
-            'ansible_type': "finish",
+        data['ansible_result'] = json.dumps(summarize_stat)  # deprecated field
-            'ansible_playbook': self.playbook,
+
-            'ansible_playbook_duration': runtime.total_seconds(),
+        if (self.ls_format_version == "v2"):
-            'ansible_result': json.dumps(summarize_stat),
+            self.logger.info(
-        }
+                "FINISH PLAYBOOK | %s", json.dumps(summarize_stat), extra=data
+            )
+        else:
             self.logger.info("ansible stats", extra=data)
 
+    def v2_playbook_on_play_start(self, play):
+        self.play_id = str(play._uuid)
+
+        if play.name:
+            self.play_name = play.name
+
+        data = self.base_data.copy()
+        data['ansible_type'] = "start"
+        data['status'] = "OK"
+        data['ansible_play_id'] = self.play_id
+        data['ansible_play_name'] = self.play_name
+
+        if (self.ls_format_version == "v2"):
+            self.logger.info("START PLAY | %s", self.play_name, extra=data)
+        else:
+            self.logger.info("ansible play", extra=data)
+
+    def v2_playbook_on_task_start(self, task, is_conditional):
+        self.task_id = str(task._uuid)
+
+    '''
+    Tasks and handler tasks are dealt with here
+    '''
+
     def v2_runner_on_ok(self, result, **kwargs):
-        data = {
+        task_name = str(result._task).replace('TASK: ', '').replace('HANDLER: ', '')
-            'status': "OK",
+
-            'host': self.hostname,
+        data = self.base_data.copy()
-            'session': self.session,
+        if task_name == 'setup':
-            'ansible_type': "task",
+            data['ansible_type'] = "setup"
-            'ansible_playbook': self.playbook,
+            data['status'] = "OK"
-            'ansible_host': result._host.name,
+            data['ansible_host'] = result._host.name
-            'ansible_task': result._task,
+            data['ansible_play_id'] = self.play_id
-            'ansible_result': self._dump_results(result._result)
+            data['ansible_play_name'] = self.play_name
-        }
+            data['ansible_task'] = task_name
+            data['ansible_facts'] = self._dump_results(result._result)
+
+            if (self.ls_format_version == "v2"):
+                self.logger.info(
+                    "SETUP FACTS | %s", self._dump_results(result._result), extra=data
+                )
+            else:
+                self.logger.info("ansible facts", extra=data)
+        else:
+            if 'changed' in result._result.keys():
+                data['ansible_changed'] = result._result['changed']
+            else:
+                data['ansible_changed'] = False
+
+            data['ansible_type'] = "task"
+            data['status'] = "OK"
+            data['ansible_host'] = result._host.name
+            data['ansible_play_id'] = self.play_id
+            data['ansible_play_name'] = self.play_name
+            data['ansible_task'] = task_name
+            data['ansible_task_id'] = self.task_id
+            data['ansible_result'] = self._dump_results(result._result)
+
+            if (self.ls_format_version == "v2"):
+                self.logger.info(
+                    "TASK OK | %s | RESULT | %s",
+                    task_name, self._dump_results(result._result), extra=data
+                )
+            else:
                 self.logger.info("ansible ok", extra=data)
 
     def v2_runner_on_skipped(self, result, **kwargs):
-        data = {
+        task_name = str(result._task).replace('TASK: ', '').replace('HANDLER: ', '')
-            'status': "SKIPPED",
+
-            'host': self.hostname,
+        data = self.base_data.copy()
-            'session': self.session,
+        data['ansible_type'] = "task"
-            'ansible_type': "task",
+        data['status'] = "SKIPPED"
-            'ansible_playbook': self.playbook,
+        data['ansible_host'] = result._host.name
-            'ansible_task': result._task,
+        data['ansible_play_id'] = self.play_id
-            'ansible_host': result._host.name
+        data['ansible_play_name'] = self.play_name
-        }
+        data['ansible_task'] = task_name
+        data['ansible_task_id'] = self.task_id
+        data['ansible_result'] = self._dump_results(result._result)
+
+        if (self.ls_format_version == "v2"):
+            self.logger.info("TASK SKIPPED | %s", task_name, extra=data)
+        else:
             self.logger.info("ansible skipped", extra=data)
 
     def v2_playbook_on_import_for_host(self, result, imported_file):
-        data = {
+        data = self.base_data.copy()
-            'status': "IMPORTED",
+        data['ansible_type'] = "import"
-            'host': self.hostname,
+        data['status'] = "IMPORTED"
-            'session': self.session,
+        data['ansible_host'] = result._host.name
-            'ansible_type': "import",
+        data['ansible_play_id'] = self.play_id
-            'ansible_playbook': self.playbook,
+        data['ansible_play_name'] = self.play_name
-            'ansible_host': result._host.name,
+        data['imported_file'] = imported_file
-            'imported_file': imported_file
+
-        }
+        if (self.ls_format_version == "v2"):
+            self.logger.info("IMPORT | %s", imported_file, extra=data)
+        else:
             self.logger.info("ansible import", extra=data)
 
     def v2_playbook_on_not_import_for_host(self, result, missing_file):
-        data = {
+        data = self.base_data.copy()
-            'status': "NOT IMPORTED",
+        data['ansible_type'] = "import"
-            'host': self.hostname,
+        data['status'] = "NOT IMPORTED"
-            'session': self.session,
+        data['ansible_host'] = result._host.name
-            'ansible_type': "import",
+        data['ansible_play_id'] = self.play_id
-            'ansible_playbook': self.playbook,
+        data['ansible_play_name'] = self.play_name
-            'ansible_host': result._host.name,
+        data['imported_file'] = missing_file
-            'missing_file': missing_file
+
-        }
+        if (self.ls_format_version == "v2"):
+            self.logger.info("NOT IMPORTED | %s", missing_file, extra=data)
+        else:
             self.logger.info("ansible import", extra=data)
 
     def v2_runner_on_failed(self, result, **kwargs):
-        data = {
+        task_name = str(result._task).replace('TASK: ', '').replace('HANDLER: ', '')
-            'status': "FAILED",
+
-            'host': self.hostname,
+        data = self.base_data.copy()
-            'session': self.session,
+        if 'changed' in result._result.keys():
-            'ansible_type': "task",
+            data['ansible_changed'] = result._result['changed']
-            'ansible_playbook': self.playbook,
+        else:
-            'ansible_host': result._host.name,
+            data['ansible_changed'] = False
-            'ansible_task': result._task,
+
-            'ansible_result': self._dump_results(result._result)
+        data['ansible_type'] = "task"
-        }
+        data['status'] = "FAILED"
+        data['ansible_host'] = result._host.name
+        data['ansible_play_id'] = self.play_id
+        data['ansible_play_name'] = self.play_name
+        data['ansible_task'] = task_name
+        data['ansible_task_id'] = self.task_id
+        data['ansible_result'] = self._dump_results(result._result)
+
         self.errors += 1
+        if (self.ls_format_version == "v2"):
+            self.logger.error(
+                "TASK FAILED | %s | HOST | %s | RESULT | %s",
+                task_name, self.hostname,
+                self._dump_results(result._result), extra=data
+            )
+        else:
             self.logger.error("ansible failed", extra=data)
 
     def v2_runner_on_unreachable(self, result, **kwargs):
-        data = {
+        task_name = str(result._task).replace('TASK: ', '').replace('HANDLER: ', '')
-            'status': "UNREACHABLE",
+
-            'host': self.hostname,
+        data = self.base_data.copy()
-            'session': self.session,
+        data['ansible_type'] = "task"
-            'ansible_type': "task",
+        data['status'] = "UNREACHABLE"
-            'ansible_playbook': self.playbook,
+        data['ansible_host'] = result._host.name
-            'ansible_host': result._host.name,
+        data['ansible_play_id'] = self.play_id
-            'ansible_task': result._task,
+        data['ansible_play_name'] = self.play_name
-            'ansible_result': self._dump_results(result._result)
+        data['ansible_task'] = task_name
-        }
+        data['ansible_task_id'] = self.task_id
+        data['ansible_result'] = self._dump_results(result._result)
+
+        self.errors += 1
+        if (self.ls_format_version == "v2"):
+            self.logger.error(
+                "UNREACHABLE | %s | HOST | %s | RESULT | %s",
+                task_name, self.hostname,
+                self._dump_results(result._result), extra=data
+            )
+        else:
             self.logger.error("ansible unreachable", extra=data)
 
     def v2_runner_on_async_failed(self, result, **kwargs):
-        data = {
+        task_name = str(result._task).replace('TASK: ', '').replace('HANDLER: ', '')
-            'status': "FAILED",
+
-            'host': self.hostname,
+        data = self.base_data.copy()
-            'session': self.session,
+        data['ansible_type'] = "task"
-            'ansible_type': "task",
+        data['status'] = "FAILED"
-            'ansible_playbook': self.playbook,
+        data['ansible_host'] = result._host.name
-            'ansible_host': result._host.name,
+        data['ansible_play_id'] = self.play_id
-            'ansible_task': result._task,
+        data['ansible_play_name'] = self.play_name
-            'ansible_result': self._dump_results(result._result)
+        data['ansible_task'] = task_name
-        }
+        data['ansible_task_id'] = self.task_id
+        data['ansible_result'] = self._dump_results(result._result)
+
         self.errors += 1
+        if (self.ls_format_version == "v2"):
+            self.logger.error(
+                "ASYNC FAILED | %s | HOST | %s | RESULT | %s",
+                task_name, self.hostname,
+                self._dump_results(result._result), extra=data
+            )
+        else:
             self.logger.error("ansible async", extra=data)