mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
Merge pull request #5333 from mvermaes/yum_fix
yum module: Attempt #2 to cause yum to fail on invalid url
This commit is contained in:
commit
297a28aa79
1 changed files with 5 additions and 1 deletions
|
@ -485,7 +485,11 @@ def install(module, items, repoq, yum_basecmd, conf_file, en_repos, dis_repos):
|
||||||
|
|
||||||
rc, out, err = module.run_command(cmd)
|
rc, out, err = module.run_command(cmd)
|
||||||
|
|
||||||
if (rc != 0 and 'Nothing to do' in err) or 'Nothing to do' in out:
|
# Fail on invalid urls:
|
||||||
|
if (rc == 1 and '://' in spec and ('No package %s available.' % spec in out or 'Cannot open: %s. Skipping.' % spec in err)):
|
||||||
|
err = 'Package at %s could not be installed' % spec
|
||||||
|
module.fail_json(changed=False,msg=err,rc=1)
|
||||||
|
elif (rc != 0 and 'Nothing to do' in err) or 'Nothing to do' in out:
|
||||||
# avoid failing in the 'Nothing To Do' case
|
# avoid failing in the 'Nothing To Do' case
|
||||||
# this may happen with an URL spec.
|
# this may happen with an URL spec.
|
||||||
# for an already installed group,
|
# for an already installed group,
|
||||||
|
|
Loading…
Reference in a new issue