ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Do not fail if we try to generate a ssh key for a user without being root

Browse source 
If we try to use the user module without being root, it fail on RHEL/Fedora
because usermod --help cannot be run. The root cause is lack of permission
due to EAL4+ certification, as seen in shadow-utils changelo.

So if we cannot run it, assume there is no append. It doesn't matter
much since we will not be able to run usermod at all with or without the
option.
This commit is contained in:
Michael Scherer 2014-04-28 12:29:57 +02:00
parent f2db460203
commit 28c373da0c
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
library/system/user
View file

@ -336,8 +336,14 @@ class User(object):
def _check_usermod_append(self): def _check_usermod_append(self):
# check if this version of usermod can append groups # check if this version of usermod can append groups
usermod_path = self.module.get_bin_path('usermod', True)
cmd = [self.module.get_bin_path('usermod', True)] # for some reason, usermod --help cannot be used by non root
# on RH/Fedora, due to lack of execute bit for others
if not os.access(usermod_path, os.X_OK):
return False
cmd = [usermod_path]
cmd.append('--help') cmd.append('--help')
rc, data1, data2 = self.execute_command(cmd) rc, data1, data2 = self.execute_command(cmd)
helpout = data1 + data2 helpout = data1 + data2