1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00

homebrew_cask: Follow up changes (#32)

Follow up changes recommended in code review

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
This commit is contained in:
Abhijeet Kasurde 2020-03-30 22:45:17 +05:30 committed by GitHub
parent 0026c9f5b2
commit 273a678771
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 14 deletions

View file

@ -0,0 +1,2 @@
minor_changes:
- Follow up changes in homebrew_cask (https://github.com/ansible/ansible/issues/34696).

View file

@ -26,16 +26,16 @@ author:
- "Enric Lluelles (@enriclluelles)" - "Enric Lluelles (@enriclluelles)"
requirements: requirements:
- "python >= 2.6" - "python >= 2.6"
short_description: Install and uninstall homebrew casks. short_description: Install and uninstall homebrew casks
description: description:
- Manages Homebrew casks. - Manages Homebrew casks.
options: options:
name: name:
description: description:
- Name of cask to install or remove. - Name of cask to install or remove.
required: true aliases: [ 'cask', 'package', 'pkg' ]
aliases: ['pkg', 'package', 'cask']
type: list type: list
elements: str
path: path:
description: description:
- "':' separated list of paths to search for 'brew' executable." - "':' separated list of paths to search for 'brew' executable."
@ -44,7 +44,7 @@ options:
state: state:
description: description:
- State of the cask. - State of the cask.
choices: [ 'present', 'absent', 'upgraded' ] choices: [ 'absent', 'installed', 'latest', 'present', 'removed', 'uninstalled', 'upgraded' ]
default: present default: present
type: str type: str
sudo_password: sudo_password:
@ -57,32 +57,33 @@ options:
- Update homebrew itself first. - Update homebrew itself first.
- Note that C(brew cask update) is a synonym for C(brew update). - Note that C(brew cask update) is a synonym for C(brew update).
type: bool type: bool
default: 'no' default: no
aliases: ['update-brew'] aliases: [ 'update-brew' ]
install_options: install_options:
description: description:
- Options flags to install a package. - Options flags to install a package.
aliases: ['options'] aliases: [ 'options' ]
type: list type: list
elements: str
accept_external_apps: accept_external_apps:
description: description:
- Allow external apps. - Allow external apps.
type: bool type: bool
default: 'no' default: no
upgrade_all: upgrade_all:
description: description:
- Upgrade all casks. - Upgrade all casks.
- Mutually exclusive with C(upgraded) state. - Mutually exclusive with C(upgraded) state.
type: bool type: bool
default: 'no' default: no
aliases: ['upgrade'] aliases: [ 'upgrade' ]
greedy: greedy:
description: description:
- Upgrade casks that auto update. - Upgrade casks that auto update.
- Passes --greedy to brew cask outdated when checking - Passes --greedy to brew cask outdated when checking
if an installed cask has a newer version available. if an installed cask has a newer version available.
type: bool type: bool
default: 'no' default: no
''' '''
EXAMPLES = ''' EXAMPLES = '''
- name: Install cask - name: Install cask
@ -749,6 +750,7 @@ def main():
aliases=["pkg", "package", "cask"], aliases=["pkg", "package", "cask"],
required=False, required=False,
type='list', type='list',
elements='str',
), ),
path=dict( path=dict(
default="/usr/local/bin", default="/usr/local/bin",
@ -777,6 +779,7 @@ def main():
default=None, default=None,
aliases=['options'], aliases=['options'],
type='list', type='list',
elements='str',
), ),
accept_external_apps=dict( accept_external_apps=dict(
default=False, default=False,

View file

@ -2974,10 +2974,7 @@ plugins/modules/packaging/os/flatpak.py validate-modules:use-run-command-not-pop
plugins/modules/packaging/os/flatpak_remote.py validate-modules:parameter-type-not-in-doc plugins/modules/packaging/os/flatpak_remote.py validate-modules:parameter-type-not-in-doc
plugins/modules/packaging/os/flatpak_remote.py validate-modules:use-run-command-not-popen plugins/modules/packaging/os/flatpak_remote.py validate-modules:use-run-command-not-popen
plugins/modules/packaging/os/homebrew.py validate-modules:parameter-invalid plugins/modules/packaging/os/homebrew.py validate-modules:parameter-invalid
plugins/modules/packaging/os/homebrew_cask.py validate-modules:doc-choices-do-not-match-spec
plugins/modules/packaging/os/homebrew_cask.py validate-modules:doc-required-mismatch
plugins/modules/packaging/os/homebrew_cask.py validate-modules:parameter-invalid plugins/modules/packaging/os/homebrew_cask.py validate-modules:parameter-invalid
plugins/modules/packaging/os/homebrew_cask.py validate-modules:parameter-list-no-elements
plugins/modules/packaging/os/installp.py validate-modules:parameter-list-no-elements plugins/modules/packaging/os/installp.py validate-modules:parameter-list-no-elements
plugins/modules/packaging/os/layman.py validate-modules:doc-missing-type plugins/modules/packaging/os/layman.py validate-modules:doc-missing-type
plugins/modules/packaging/os/layman.py validate-modules:undocumented-parameter plugins/modules/packaging/os/layman.py validate-modules:undocumented-parameter