ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Ensure that filenames from archives are not expanded

Browse source 
This fixes #21795
This commit is contained in:
Dag Wieers 2017-02-24 01:12:55 +01:00 committed by Toshio Kuratomi
parent 7966beb6c9
commit 237411613d
2 changed files with 38 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
lib/ansible/module_utils/basic.py
View file

@ -902,10 +902,11 @@ class AnsibleModule(object):
context = ret[1].split(':', 3) context = ret[1].split(':', 3)
return context return context
def user_and_group(self, filename): def user_and_group(self, path, expand=True):
filename = os.path.expanduser(os.path.expandvars(filename)) b_path = to_bytes(path, errors='surrogate_then_strict')
b_filename = to_bytes(filename, errors='surrogate_or_strict') if expand:
st = os.lstat(b_filename) b_path = os.path.expanduser(os.path.expandvars(b_path))
st = os.lstat(b_path)
uid = st.st_uid uid = st.st_uid
gid = st.st_gid gid = st.st_gid
return (uid, gid) return (uid, gid)
@ -987,12 +988,14 @@ class AnsibleModule(object):
changed = True changed = True
return changed return changed
def set_owner_if_different(self, path, owner, changed, diff=None): def set_owner_if_different(self, path, owner, changed, diff=None, expand=True):
path = os.path.expanduser(os.path.expandvars(path)) b_path = to_bytes(path, errors='surrogate_then_strict')
b_path = to_bytes(path, errors='surrogate_or_strict') if expand:
b_path = os.path.expanduser(os.path.expandvars(b_path))
path = to_text(b_path, errors='surrogate_then_strict')
if owner is None: if owner is None:
return changed return changed
orig_uid, orig_gid = self.user_and_group(path) orig_uid, orig_gid = self.user_and_group(path, expand)
try: try:
uid = int(owner) uid = int(owner)
except ValueError: except ValueError:
@ -1019,12 +1022,14 @@ class AnsibleModule(object):
changed = True changed = True
return changed return changed
def set_group_if_different(self, path, group, changed, diff=None): def set_group_if_different(self, path, group, changed, diff=None, expand=True):
path = os.path.expanduser(os.path.expandvars(path)) b_path = to_bytes(path, errors='surrogate_then_strict')
b_path = to_bytes(path, errors='surrogate_or_strict') if expand:
b_path = os.path.expanduser(os.path.expandvars(b_path))
path = to_text(b_path, errors='surrogate_then_strict')
if group is None: if group is None:
return changed return changed
orig_uid, orig_gid = self.user_and_group(b_path) orig_uid, orig_gid = self.user_and_group(b_path, expand)
try: try:
gid = int(group) gid = int(group)
except ValueError: except ValueError:
@ -1051,9 +1056,11 @@ class AnsibleModule(object):
changed = True changed = True
return changed return changed
def set_mode_if_different(self, path, mode, changed, diff=None): def set_mode_if_different(self, path, mode, changed, diff=None, expand=True):
b_path = to_bytes(path, errors='surrogate_or_strict') b_path = to_bytes(path, errors='surrogate_then_strict')
if expand:
b_path = os.path.expanduser(os.path.expandvars(b_path)) b_path = os.path.expanduser(os.path.expandvars(b_path))
path = to_text(b_path, errors='surrogate_then_strict')
path_stat = os.lstat(b_path) path_stat = os.lstat(b_path)
if mode is None: if mode is None:
@ -1125,14 +1132,15 @@ class AnsibleModule(object):
changed = True changed = True
return changed return changed
def set_attributes_if_different(self, path, attributes, changed, diff=None): def set_attributes_if_different(self, path, attributes, changed, diff=None, expand=True):
if attributes is None: if attributes is None:
return changed return changed
b_path = to_bytes(path, errors='surrogate_or_strict') b_path = to_bytes(path, errors='surrogate_then_strict')
if expand:
b_path = os.path.expanduser(os.path.expandvars(b_path)) b_path = os.path.expanduser(os.path.expandvars(b_path))
existing = self.get_file_attributes(b_path) path = to_text(b_path, errors='surrogate_then_strict')
if existing.get('attr_flags','') != attributes: if existing.get('attr_flags','') != attributes:
attrcmd = self.get_bin_path('chattr') attrcmd = self.get_bin_path('chattr')
@ -1273,30 +1281,30 @@ class AnsibleModule(object):
or_reduce = lambda mode, perm: mode | user_perms_to_modes[user][perm] or_reduce = lambda mode, perm: mode | user_perms_to_modes[user][perm]
return reduce(or_reduce, perms, 0) return reduce(or_reduce, perms, 0)
def set_fs_attributes_if_different(self, file_args, changed, diff=None): def set_fs_attributes_if_different(self, file_args, changed, diff=None, expand=True):
# set modes owners and context as needed # set modes owners and context as needed
changed = self.set_context_if_different( changed = self.set_context_if_different(
file_args['path'], file_args['secontext'], changed, diff file_args['path'], file_args['secontext'], changed, diff
) )
changed = self.set_owner_if_different( changed = self.set_owner_if_different(
file_args['path'], file_args['owner'], changed, diff file_args['path'], file_args['owner'], changed, diff, expand
) )
changed = self.set_group_if_different( changed = self.set_group_if_different(
file_args['path'], file_args['group'], changed, diff file_args['path'], file_args['group'], changed, diff, expand
) )
changed = self.set_mode_if_different( changed = self.set_mode_if_different(
file_args['path'], file_args['mode'], changed, diff file_args['path'], file_args['mode'], changed, diff, expand
) )
changed = self.set_attributes_if_different( changed = self.set_attributes_if_different(
file_args['path'], file_args['attributes'], changed, diff file_args['path'], file_args['attributes'], changed, diff, expand
) )
return changed return changed
def set_directory_attributes_if_different(self, file_args, changed, diff=None): def set_directory_attributes_if_different(self, file_args, changed, diff=None, expand=True):
return self.set_fs_attributes_if_different(file_args, changed, diff) return self.set_fs_attributes_if_different(file_args, changed, diff, expand)
def set_file_attributes_if_different(self, file_args, changed, diff=None): def set_file_attributes_if_different(self, file_args, changed, diff=None, expand=True):
return self.set_fs_attributes_if_different(file_args, changed, diff) return self.set_fs_attributes_if_different(file_args, changed, diff, expand)
def add_path_info(self, kwargs): def add_path_info(self, kwargs):
''' '''

4
lib/ansible/modules/files/unarchive.py
View file

@ -865,10 +865,10 @@ def main():
for filename in handler.files_in_archive: for filename in handler.files_in_archive:
file_args['path'] = os.path.join(dest, filename) file_args['path'] = os.path.join(dest, filename)
try: try:
res_args['changed'] = module.set_fs_attributes_if_different(file_args, res_args['changed']) res_args['changed'] = module.set_fs_attributes_if_different(file_args, res_args['changed'], expand=False)
except (IOError, OSError): except (IOError, OSError):
e = get_exception() e = get_exception()
module.fail_json(msg="Unexpected error when accessing exploded file: %s" % str(e), **res_args) module.fail_json(msg="Unexpected error when accessing exploded file: %s" % e, **res_args)
if module.params['list_files']: if module.params['list_files']:
res_args['files'] = handler.files_in_archive res_args['files'] = handler.files_in_archive