ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Pacman: Fix name of URL packages (#4959) (#4970)

Browse source 
* Strip downloading... of unseen URLs

* Added changelog fragment

* Added integration tests for reason and reason_for

Inspired by the integration tests for url packages

* Revert "Added integration tests for reason and reason_for"

This reverts commit f60d92f0d7.

Accidentally commited to the wrong branch.

(cherry picked from commit 788cfb624a)

Co-authored-by: Minei3oat <Minei3oat@users.noreply.github.com>
This commit is contained in:
patchback[bot] 2022-07-21 20:16:24 +02:00 committed by GitHub
parent 8854f4d948
commit 22773418d2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/4959-pacman-fix-url-packages-name.yaml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- pacman - fixed name resolution of URL packages (https://github.com/ansible-collections/community.general/pull/4959).

5
plugins/modules/packaging/os/pacman.py
View file

@ -636,8 +636,9 @@ class Pacman(object):
stderr=stderr, stderr=stderr,
rc=rc, rc=rc,
) )
# With Pacman v6.0.1 - libalpm v13.0.1, --upgrade outputs "loading packages..." on stdout. strip that # With Pacman v6.0.1 - libalpm v13.0.1, --upgrade outputs " filename_without_extension downloading..." if the URL is unseen.
stdout = stdout.replace("loading packages...\n", "") # In all cases, pacman outputs "loading packages..." on stdout. strip both
stdout = stdout.splitlines()[-1]
is_URL = True is_URL = True
pkg_name = stdout.strip() pkg_name = stdout.strip()
pkg_list.append(Package(name=pkg_name, source=pkg, source_is_URL=is_URL)) pkg_list.append(Package(name=pkg_name, source=pkg, source_is_URL=is_URL))