ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

vmware_datastore_facts: empty list if none found

Browse source 
When `vmware_datastore_facts` does not fine any datastore, it raises an error.
This is not consistent with the other _facts modules. It should just return
an empty list instead.
This commit is contained in:
Gonéri Le Bouder 2019-04-04 13:14:58 -04:00
parent ad2c7ec9d7
commit 223321e7e2
2 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/vmware_datastore_facts.yaml Normal file
View file

@ -0,0 +1,2 @@
minor_changes:
- vmware_datastore_facts - When no datastore was found, returns an empty list.

10
lib/ansible/modules/cloud/vmware/vmware_datastore_facts.py
View file

@ -277,15 +277,7 @@ def main():
result['datastores'] = datastores result['datastores'] = datastores
# found a datastore module.exit_json(**result)
if datastores:
module.exit_json(**result)
else:
msg = "Unable to gather datastore facts"
if module.params['name']:
msg += " for %(name)s" % module.params
msg += " in datacenter %(datacenter)s" % module.params
module.fail_json(msg=msg)
if __name__ == '__main__': if __name__ == '__main__':