ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Rename AWS unit tests that are not running when changing the module (#42712)

Browse source 
now can use `ansible-test units module_name` for the aws_s3 and aws_api_gateway modules

changes to modules/cloud/amazon/aws_api_gateway and modules/cloud/amazon/aws_s3 are not triggering the unit tests; also fix aws_s3 from importing non-exist module and skipping tests

changes to module_utils/aws/core.py are only being unit tested on modules that import from the file (if they have a corresponding test) or tests that import from the file themselves.
This commit is contained in:
Sloane Hertel 2018-07-13 10:56:57 -04:00 committed by Ryan Brown
parent 7a0c28cc37
commit 1fdd84b88c
2 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

0
test/units/modules/cloud/amazon/test_api_gateway.py → test/units/modules/cloud/amazon/test_aws_api_gateway.py
View file

9
test/units/modules/cloud/amazon/test_s3.py → test/units/modules/cloud/amazon/test_aws_s3.py
View file

@ -3,7 +3,7 @@ import pytest
import unittest import unittest
try: try:
import ansible.modules.cloud.amazon.s3 as s3 import ansible.modules.cloud.amazon.aws_s3 as s3
except ImportError: except ImportError:
pytestmark = pytest.mark.skip("This test requires the s3 Python libraries") pytestmark = pytest.mark.skip("This test requires the s3 Python libraries")
@ -24,13 +24,6 @@ class TestUrlparse(unittest.TestCase):
actual = s3.is_fakes3("fakes3://bla.blubb") actual = s3.is_fakes3("fakes3://bla.blubb")
self.assertEqual(True, actual) self.assertEqual(True, actual)
def test_is_walrus(self):
actual = s3.is_walrus("trulywalrus_but_invalid_url")
# I don't know if this makes sense, but this is the current behaviour...
self.assertEqual(True, actual)
actual = s3.is_walrus("http://notwalrus.amazonaws.com")
self.assertEqual(False, actual)
def test_get_s3_connection(self): def test_get_s3_connection(self):
aws_connect_kwargs = dict(aws_access_key_id="access_key", aws_connect_kwargs = dict(aws_access_key_id="access_key",
aws_secret_access_key="secret_key") aws_secret_access_key="secret_key")