ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

add deprecation warning for python-dnsimple 1 (#3267)

Browse source 
* add deprecation warning for python-dnsimple 1

* add changelog fragment

* Update changelogs/fragments/3267-dnsimple1-deprecation.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/net_tools/dnsimple.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* fix typo

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/net_tools/dnsimple.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/3267-dnsimple1-deprecation.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
Reto Kupferschmid 2021-08-29 13:20:46 +02:00 committed by GitHub
parent df8fdcda79
commit 1ce79db763
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
changelogs/fragments/3267-dnsimple1-deprecation.yml Normal file
View file

@ -0,0 +1,3 @@
---
deprecated_features:
- "dnsimple - python-dnsimple < 2.0.0 is deprecated and support for it will be removed in community.general 5.0.0 (https://github.com/ansible-collections/community.general/pull/2946#discussion_r667624693)."

7
plugins/modules/net_tools/dnsimple.py
View file

@ -82,6 +82,8 @@ options:
version_added: 3.5.0 version_added: 3.5.0
requirements: requirements:
- "dnsimple >= 1.0.0" - "dnsimple >= 1.0.0"
notes:
- "Support for C(dnsimple < 2) is deprecated and will be removed in community.general 5.0.0."
author: "Alex Coomans (@drcapulet)" author: "Alex Coomans (@drcapulet)"
''' '''
@ -402,6 +404,11 @@ def main():
if DNSIMPLE_MAJOR_VERSION > 1: if DNSIMPLE_MAJOR_VERSION > 1:
ds = DNSimpleV2(account_email, account_api_token, sandbox, module) ds = DNSimpleV2(account_email, account_api_token, sandbox, module)
else: else:
module.deprecate(
'Support for python-dnsimple < 2 is deprecated. '
'Update python-dnsimple to version >= 2.0.0',
version='5.0.0', collection_name='community.general'
)
ds = DNSimpleV1(account_email, account_api_token, sandbox, module) ds = DNSimpleV1(account_email, account_api_token, sandbox, module)
# Let's figure out what operation we want to do # Let's figure out what operation we want to do
# No domain, return a list # No domain, return a list