From 1a2fa802c0ccc4b6bef0c6d441050fd8d3a489f9 Mon Sep 17 00:00:00 2001 From: Alexei Znamensky <103110+russoz@users.noreply.github.com> Date: Wed, 18 May 2022 05:26:06 +1200 Subject: [PATCH] [6.0.0] xfconf - deprecate parameter disable_facts (#4520) * xfconf: deprecate parameter disable_facts * added changelog fragment * changed deprecation to 8.0.0 * Update changelogs/fragments/4520-xfconf-deprecate-disable-facts.yml Co-authored-by: Felix Fontein * added parameter deprecation Co-authored-by: Felix Fontein --- .../fragments/4520-xfconf-deprecate-disable-facts.yml | 2 ++ plugins/modules/system/xfconf.py | 8 ++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 changelogs/fragments/4520-xfconf-deprecate-disable-facts.yml diff --git a/changelogs/fragments/4520-xfconf-deprecate-disable-facts.yml b/changelogs/fragments/4520-xfconf-deprecate-disable-facts.yml new file mode 100644 index 0000000000..d2af2bc9df --- /dev/null +++ b/changelogs/fragments/4520-xfconf-deprecate-disable-facts.yml @@ -0,0 +1,2 @@ +deprecated_features: + - xfconf - deprecated parameter ``disable_facts``, as since version 4.0.0 it only allows value ``true`` (https://github.com/ansible-collections/community.general/pull/4520). diff --git a/plugins/modules/system/xfconf.py b/plugins/modules/system/xfconf.py index 8becd4a683..20213dd348 100644 --- a/plugins/modules/system/xfconf.py +++ b/plugins/modules/system/xfconf.py @@ -77,7 +77,7 @@ options: disable_facts: description: - The value C(false) is no longer allowed since community.general 4.0.0. - - This option will be deprecated in a future version, and eventually be removed. + - This option is deprecated, and will be removed in community.general 8.0.0. type: bool default: true version_added: 2.1.0 @@ -183,7 +183,11 @@ class XFConfProperty(CmdStateModuleHelper): choices=('string', 'int', 'double', 'bool', 'uint', 'uchar', 'char', 'uint64', 'int64', 'float')), value=dict(type='list', elements='raw'), force_array=dict(type='bool', default=False, aliases=['array']), - disable_facts=dict(type='bool', default=True), + disable_facts=dict( + type='bool', default=True, + removed_in_version='8.0.0', + removed_from_collection='community.general' + ), ), required_if=[('state', 'present', ['value', 'value_type'])], required_together=[('value', 'value_type')],