ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Python 3: fix TypeError: unorderable types in test

Browse source 
The full error was

======================================================================
ERROR: test_task_executor_execute (units.executor.test_task_executor.TestTaskExecutor)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/mg/src/ansible/test/units/executor/test_task_executor.py", line 252, in test_task_executor_execute
    mock_action.run.return_value = dict(ansible_facts=dict())
  File "/home/mg/src/ansible/lib/ansible/executor/task_executor.py", line 317, in _execute
    if self._task.async > 0:
TypeError: unorderable types: MagicMock() > int()

----------------------------------------------------------------------

Experiments show that Python 2 MagicMock() > 0 is true, so I'm setting
the async property on mock_task to 1.  (If I set it to 0, the test fails
anyway.)
This commit is contained in:
Marius Gedminas 2015-09-07 09:49:28 +03:00
parent 718812d945
commit 1a1c9203e2
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
test/units/executor/test_task_executor.py
View file

@ -220,6 +220,7 @@ class TestTaskExecutor(unittest.TestCase):
mock_task.changed_when = None
mock_task.failed_when = None
mock_task.post_validate.return_value = None
mock_task.async = 1
mock_play_context = MagicMock()
mock_play_context.post_validate.return_value = None