ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

launchd - fixed validation check (#2960)

Browse source 
* replaced use of expanduser() with value from HOME var

* fixed sanity check

* added changelog fragment
This commit is contained in:
Alexei Znamensky 2021-07-10 23:03:41 +12:00 committed by GitHub
parent ad8c4e4de6
commit 1990f79d8a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/2960-launchd-validation-check.yaml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- launchd - fixed sanity check in the module's code (https://github.com/ansible-collections/community.general/pull/2960).

2
plugins/modules/system/launchd.py
View file

@ -159,7 +159,7 @@ class Plist:
"""Finds the plist file associated with a service"""
launchd_paths = [
os.path.expanduser('~/Library/LaunchAgents'),
os.path.join(os.getenv('HOME'), 'Library/LaunchAgents'),
'/Library/LaunchAgents',
'/Library/LaunchDaemons',
'/System/Library/LaunchAgents',

1
tests/sanity/ignore-2.10.txt
View file

@ -41,7 +41,6 @@ plugins/modules/remote_management/manageiq/manageiq_tags.py validate-modules:par
plugins/modules/source_control/github/github_deploy_key.py validate-modules:parameter-invalid
plugins/modules/system/gconftool2.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/iptables_state.py validate-modules:undocumented-parameter
plugins/modules/system/launchd.py use-argspec-type-path # False positive
plugins/modules/system/osx_defaults.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/parted.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/puppet.py use-argspec-type-path

1
tests/sanity/ignore-2.11.txt
View file

@ -40,7 +40,6 @@ plugins/modules/remote_management/manageiq/manageiq_tags.py validate-modules:par
plugins/modules/source_control/github/github_deploy_key.py validate-modules:parameter-invalid
plugins/modules/system/gconftool2.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/iptables_state.py validate-modules:undocumented-parameter
plugins/modules/system/launchd.py use-argspec-type-path # False positive
plugins/modules/system/osx_defaults.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/parted.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/puppet.py use-argspec-type-path

1
tests/sanity/ignore-2.12.txt
View file

@ -40,7 +40,6 @@ plugins/modules/remote_management/manageiq/manageiq_tags.py validate-modules:par
plugins/modules/source_control/github/github_deploy_key.py validate-modules:parameter-invalid
plugins/modules/system/gconftool2.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/iptables_state.py validate-modules:undocumented-parameter
plugins/modules/system/launchd.py use-argspec-type-path # False positive
plugins/modules/system/osx_defaults.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/parted.py validate-modules:parameter-state-invalid-choice
plugins/modules/system/puppet.py use-argspec-type-path

1
tests/sanity/ignore-2.9.txt
View file

@ -62,7 +62,6 @@ plugins/modules/net_tools/nios/nios_zone.py validate-modules:deprecation-mismatc
plugins/modules/net_tools/nios/nios_zone.py validate-modules:invalid-documentation
plugins/modules/source_control/github/github_deploy_key.py validate-modules:parameter-invalid
plugins/modules/system/iptables_state.py validate-modules:undocumented-parameter
plugins/modules/system/launchd.py use-argspec-type-path # False positive
plugins/modules/system/puppet.py use-argspec-type-path
plugins/modules/system/puppet.py validate-modules:parameter-type-not-in-doc
plugins/modules/system/runit.py validate-modules:parameter-type-not-in-doc # deprecated param - removed in 4.0.0