From 17c50cc81e291d63f1df6c44b6499aa0200a0ec4 Mon Sep 17 00:00:00 2001 From: James Tanner Date: Tue, 14 Jan 2014 10:48:57 -0500 Subject: [PATCH] sysctl module: fail if reloading the file did not succeed --- library/system/sysctl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/library/system/sysctl b/library/system/sysctl index 54f116c6c1..050c2effb1 100644 --- a/library/system/sysctl +++ b/library/system/sysctl @@ -189,8 +189,9 @@ class SysctlModule(object): else: # system supports reloading via the -p flag to sysctl, so we'll use that rc,out,err = self.module.run_command([self.sysctl_cmd, '-p', self.sysctl_file]) - - return rc,out+err + + if rc != 0: + self.module.fail_json(msg="Failed to reload sysctl: %s" % str(out) + str(err)) # ============================================================== # SYSCTL FILE MANAGEMENT