ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Make vars plugins honor hash_behaviour setting.

Browse source 
When applying precedence ordering of different classes of vars
(hostvars, groupvars, role-defaults, etc.), the hash_behaviour
setting controls whether duplicate hash keys are replaced in
entirety, or merged together.

The wording of the documentation suggests that this setting applies
to all levels of the precedence ordering, when it currently does not:

> Ansible by default will override variables in specific precedence orders,
> as described in Variables. When a variable of higher precedence wins,
> it will replace the other value. ... Some users prefer that variables that
> are hashes (aka ‘dictionaries’ in Python terms) are merged together. This
> setting is called ‘merge’.

This change causes the hash_behavior setting to extend to vars plugins.
This commit is contained in:
Tim Miller 2014-01-20 15:27:37 -08:00
parent c17d0e0357
commit 13432bb18d
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/ansible/inventory/__init__.py
View file

@ -341,12 +341,12 @@ class Inventory(object):
raise errors.AnsibleError("host not found: %s" % hostname) raise errors.AnsibleError("host not found: %s" % hostname)
vars = {} vars = {}
vars_results = [ plugin.run(host) for plugin in self._vars_plugins ] vars_results = [ plugin.run(host) for plugin in self._vars_plugins ]
for updated in vars_results: for updated in vars_results:
if updated is not None: if updated is not None:
vars.update(updated) vars = utils.combine_vars(vars, updated)
vars.update(host.get_variables()) vars = utils.combine_vars(vars, host.get_variables())
if self.parser is not None: if self.parser is not None:
vars = utils.combine_vars(vars, self.parser.get_host_variables(host)) vars = utils.combine_vars(vars, self.parser.get_host_variables(host))
return vars return vars