[PR #8091/67736d79 backport][stable-8] Fix consul_token usage without accessor_id. (#8097)

Fix consul_token usage without accessor_id. (#8091)

* Fix consul_token usage without accessor_id.

* Update changelogs/fragments/8091-consul-token-fixes.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/consul_token.py

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 67736d796a)

Co-authored-by: Florian Apolloner <florian@apolloner.eu>

changelogs/fragments/8091-consul-token-fixes.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - "consul_token - fix token creation without ``accessor_id`` (https://github.com/ansible-collections/community.general/pull/8091)."

plugins/module_utils/consul.py

@@ -277,7 +277,7 @@ class _ConsulModule:
             headers["X-Consul-Token"] = token
 
         try:
-            if data:
+            if data is not None:
                 data = json.dumps(data)
                 headers["Content-Type"] = "application/json"
             if params:

plugins/modules/consul_token.py

@@ -237,6 +237,12 @@ class ConsulTokenModule(_ConsulModule):
 
     create_only_fields = {"expiration_ttl"}
 
+    def read_object(self):
+        # if `accessor_id` is not supplied we can only create objects and are not idempotent
+        if not self.params.get(self.unique_identifier):
+            return None
+        return super(ConsulTokenModule, self).read_object()
+
     def needs_update(self, api_obj, module_obj):
         # SecretID is usually not supplied
         if "SecretID" not in module_obj and "SecretID" in api_obj:

tests/integration/targets/consul/tasks/consul_token.yml

@@ -14,6 +14,17 @@
     - foo-access
     - foo-access2
 
+- name: Create token without accessor
+  community.general.consul_token:
+    state: present
+  register: simple_create_result
+
+- assert:
+    that:
+      - simple_create_result is changed
+      - simple_create_result.token.AccessorID
+      - simple_create_result.operation == 'create'
+
 - name: Create token
   community.general.consul_token:
     state: present